Backport "Ensure translatable resources save their fields as JSON objects" to 0.23-stable#6646
Merged
tramuntanal merged 1 commit intorelease/0.23-stablefrom Oct 8, 2020
Conversation
* Ensure translatable resources save their fields as JSON objects Instead of strings. * Lint files * Don't make collaborative drafts translatable * Don't make proposal notes translatable * Don't make surveys translatable * Remove missing field * Fix pages specs * Fix budgets specs * Fix comments specs * Fix assemblies specs * Fix core tests * Fix debates specs * Don't translate answer choices * Fix initiatives specs * Lint files * Lint more files * Fix meetings * Fix process specs * Fix proposals unit tests * Fix proposals admin system specs * Remove unused property * Fix proposal public system specs * Fix spec * Fix more accountability specs * Fix core specs * Fix proposals factories * Ensure attachments title and description are hashes * Lint file * Fix migration * Improve migration * Lint file * Fix proposals specs
mrcasals
approved these changes
Oct 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Please describe your pull request.
Backports #6587 to what's going to be 0.23.0.rc1 by cerry-picking the commit into
release/0.23-stable.📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
