Conversation
|
Hi @josepjaume, glad to see you again here :D As far as I'm aware when you say "user" you're referring to Administrators, right?
That'd be great! On the other hand, we prefer to be not so transparent on explaining publicly how to exploit current unsolved vulnerabilities. We have a Security Policy for these cases. Thanks for the PR! |
|
I can confirm the exploit and the fix locally. |
35d5eee to
5dc0a4f
Compare
|
Oh!, that's a great solution to fix this issue. But can you create some test for the modified view and cell, please? |
ivan-mr
left a comment
There was a problem hiding this comment.
Now I see all checks have passed. Thanks @josepjaume and good job!
|
Thanks @ivan-mr! I was about to write the tests for this, but they looked a bit too specific to me. Maybe we should find a way to ensure things get properly escaped in all cells? |
🎩 What? Why?
This escapes some user input fields on the
conferencesmodule that weren't properly escaped.Note: As it turns out,
cellsare not escaped by default. Maybe we should consider adding theEscapedmodule sometime.📌 Related Issues
None
Testing
Add
"><h1><font color=red>XSS_Conference_title</font></h1><img src=x onerror=alert(1)>as an user input on a conference, and check out a related activity on your profile. You should see the title escaped.📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
None