Skip to content

Fix default help section and page for Conferences and consultations#6618

Merged
Leusev merged 3 commits intodevelopfrom
fix/default-help-conferences
Oct 14, 2020
Merged

Fix default help section and page for Conferences and consultations#6618
Leusev merged 3 commits intodevelopfrom
fix/default-help-conferences

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

Please describe your pull request.

As I was making some docs I found out that we didn't have default help contents for Conferences. This PR adds these texts.

Also I fixed a minor thing in Consultations help, that it was written in plural; the rest were in singular, and it wasn't consistent.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

  1. Start with a new database (without seeds)
  2. Log in as admin
  3. Go to http://localhost:3000/admin/help_sections?locale=en
  4. See the Conferences textarea with default text

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing

Before

help_sections_backend

After

imatge
imatge

♥️ Thank you!

@andreslucena andreslucena changed the title Fix/default help conferences Fix default help section and page for Conferences Oct 7, 2020
@Leusev Leusev self-requested a review October 14, 2020 07:32
@Leusev Leusev self-assigned this Oct 14, 2020
@Leusev Leusev merged commit 402bd30 into develop Oct 14, 2020
@Leusev Leusev deleted the fix/default-help-conferences branch October 14, 2020 08:32
@mrcasals mrcasals changed the title Fix default help section and page for Conferences Fix default help section and page for Conferences and consultations Feb 25, 2021
@mrcasals mrcasals added module: conferences module: consultations type: change PRs that implement a change for an existing feature and removed module: consultations type: change PRs that implement a change for an existing feature labels Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-review module: conferences type: change PRs that implement a change for an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default text for Conferences in Help sections

3 participants