Skip to content

Fix order for elections#6616

Merged
Leusev merged 2 commits intodevelopfrom
fix/elections_filtering
Oct 13, 2020
Merged

Fix order for elections#6616
Leusev merged 2 commits intodevelopfrom
fix/elections_filtering

Conversation

@slickepinne
Copy link
Copy Markdown
Contributor

@slickepinne slickepinne commented Oct 7, 2020

🎩 What? Why?

The elections filter for recent and older elections were twisted. This PR fixes it, so that recent will order desc from an elections' start_time.

📌 Related Issues

Testing

I updated the system test but you can also go to the elections component and change the order between recent and older.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing

♥️ Thank you!

@slickepinne slickepinne self-assigned this Oct 7, 2020
leio10
leio10 previously approved these changes Oct 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

agustibr
agustibr previously approved these changes Oct 7, 2020
View reviewed changes
@slickepinne slickepinne dismissed stale reviews from agustibr and leio10 via e1c0773 October 7, 2020 10:01
@slickepinne slickepinne force-pushed the fix/elections_filtering branch from e1c0773 to 909c02a Compare October 7, 2020 16:56
@slickepinne
Copy link
Copy Markdown
Contributor Author

slickepinne commented Oct 8, 2020

Hi @decidim/product, this fix can get reviewed here.

@carolromero
Copy link
Copy Markdown
Member

carolromero commented Oct 9, 2020

@slickepinne checked, thank you!

@slickepinne
Copy link
Copy Markdown
Contributor Author

slickepinne commented Oct 9, 2020

@decidim/core This is ready to get reviewed. 😊

@Leusev Leusev self-requested a review October 13, 2020 14:18
Leusev
Leusev approved these changes Oct 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Leusev Leusev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me @slickepinne 👍

@Leusev Leusev merged commit b4606d6 into develop Oct 13, 2020
@Leusev Leusev deleted the fix/elections_filtering branch October 13, 2020 14:24
@mrcasals mrcasals added type: fix PRs that implement a fix for a bug and removed type: bug labels Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gchacart gchacart Awaiting requested review from gchacart

3 more reviewers

@Leusev Leusev Leusev approved these changes

@agustibr agustibr agustibr left review comments

@leio10 leio10 leio10 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@slickepinne slickepinne

Labels

in-review module: elections type: fix PRs that implement a fix for a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@slickepinne @carolromero @agustibr @leio10 @Leusev @mrcasals