Skip to content

Use a more neutral vocabulary on initiatives#6590

Merged
Leusev merged 3 commits intodevelopfrom
fix/initiative_neutral_vocabulary
Oct 14, 2020
Merged

Use a more neutral vocabulary on initiatives#6590
Leusev merged 3 commits intodevelopfrom
fix/initiative_neutral_vocabulary

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

Please describe your pull request.

Changes this vocabulary specific for a city/municipal context to something much more neutral.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

Navigate to the initiatives and see the changes. You shouldn't see any reference to "city/citizen/citizenship/etc"

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing

imatge

imatge

♥️ Thank you!

Changes this vocabulary specific for a city/municipal context to
something much more neutral.
Copy link
Copy Markdown
Contributor

@Leusev Leusev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

@Leusev Leusev merged commit f55df44 into develop Oct 14, 2020
@Leusev Leusev deleted the fix/initiative_neutral_vocabulary branch October 14, 2020 06:57
@mrcasals mrcasals added module: initiatives type: change PRs that implement a change for an existing feature labels Feb 25, 2021
@mrcasals mrcasals changed the title Fix Initiative's neutral vocabulary Use a more neutral vocabulary on initiatives Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-review module: initiatives type: change PRs that implement a change for an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eliminate specific AAPP vocabulary for neutral vocabulary for initiatives

4 participants