Fix error when saving an Initiative title and description from Admin#6581
Merged
tramuntanal merged 1 commit intodevelopfrom Oct 14, 2020
Merged
Fix error when saving an Initiative title and description from Admin#6581tramuntanal merged 1 commit intodevelopfrom
tramuntanal merged 1 commit intodevelopfrom
Conversation
Leusev
reviewed
Oct 7, 2020
Contributor
Leusev
left a comment
There was a problem hiding this comment.
Looks good for me @andreslucena
Altought there's a [CI] Surveys test failing... it's strange, 'cause doesn't seem related to this fix..

I launched all Surveys tests in local and all passed ok. I repeated with same seed and they worked too..

Maybe flaky? By the moment, I rerun the tests
Contributor
|
It failed again but due to a different error... We should analyze what's happening here |
tramuntanal
approved these changes
Oct 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Please describe your pull request.
This PR fix an error when editing from admin an Initiative title and description.
It's well described at #5911 :
Thanks @virgile-dev for reporting this one!
I'm not sure if we should add a spec for this one, as there are lots of places where it's used translatable_presence and it seems like it only slipped in this form.
📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
Before
After