Remove show_statistics checkbox in Appearance#6575
Merged
tramuntanal merged 8 commits intodecidim:developfrom Oct 14, 2020
andreslucena:feature/remove_show_statistics
Merged
Remove show_statistics checkbox in Appearance#6575tramuntanal merged 8 commits intodecidim:developfrom andreslucena:feature/remove_show_statistics
tramuntanal merged 8 commits intodecidim:developfrom
andreslucena:feature/remove_show_statistics
Conversation
andreslucena
commented
Oct 1, 2020
decidim-admin/app/commands/decidim/admin/update_organization_appearance.rb
Show resolved
Hide resolved
Member
Author
|
Ready to be reviewed @decidim/core |
Member
Author
|
@decidim/product ping 👼 |
Contributor
|
@andreslucena I see you pinged @decidim/product , should we wait for product's feedback before merging? |
…ove_show_statistics
Member
Author
No, it's not necessary, I've talked offline with @carolromero and she approves this one 😄 |
tramuntanal
approved these changes
Oct 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
I was writing some docs and I found out this "Show statistics" checkbox in Appearance.
This is a legacy setting, introduced in #552 that doesn't make sense after the ContentBlocks introduction of the homepage (see #3839). This PR removes this unnecessary setting.
📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
Go to
Admin -> Settings -> Appearance, see that there's no "show statistics" setting.📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing