Backport "Improve proposal selection" to v0.22#6387
Merged
ivan-mr merged 1 commit intodecidim:release/0.22-stablefrom Aug 11, 2020
Merged
Backport "Improve proposal selection" to v0.22#6387ivan-mr merged 1 commit intodecidim:release/0.22-stablefrom
ivan-mr merged 1 commit intodecidim:release/0.22-stablefrom
Conversation
* Implement proposals picker for budgeting projects * Fix specs broken by the proposals picker implementation * Add extra specs to test the proposals picker functionality * Remove unnecessary newline * Remove unnecessary published check from proposals with the picker * Only display published proposals in the proposals picker
Contributor
Author
|
If you have doubts why this might be important, please consult @andreslucena. |
ivan-mr
approved these changes
Aug 10, 2020
Contributor
ivan-mr
left a comment
There was a problem hiding this comment.
Everything looks correct. I have detected that the codecov / patch percentage is low, but you have already commented on this issue in the related PR.
Thanks @ahukkanen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Backports #6213 to release/0.22-stable branch.
📌 Related Issues