Skip to content

Add elections list filter and sorting#6386

Merged
tramuntanal merged 42 commits intodevelopfrom
feature/add-elections-list-filter
Aug 27, 2020
Merged

Add elections list filter and sorting#6386
tramuntanal merged 42 commits intodevelopfrom
feature/add-elections-list-filter

Conversation

@slickepinne
Copy link
Copy Markdown
Contributor

@slickepinne slickepinne commented Aug 6, 2020

🎩 What? Why?

For visitors, it should be possible to filter and sort elections depending on the elections' status: active, upcoming or finished. They can sort for recent or older elections. Also, the pagination filter is added.
When only one election is given, the visitor gets redirected to the election page.
When there's no active, upcoming or none election, the visitor sees a warning.

📌 Related Issues

📋 Subtasks

  • Add tests
  • Add filter for election status
  • Add sorting filter for election
  • Add result filter for election
  • Add warnings when none or only finished elections available
  • Add redirection if only one election is given

📷 Screenshots (optional)

When there's no filter selected, recent is the default the order:
no_filter_recent

When order for older elections:
older_elections

No active elections:
no_active_elections

Only one active election (no all elections link):
one_active_election

Alert for finished elections:
finished_elections_alert

agustibr
agustibr previously approved these changes Aug 10, 2020
Copy link
Copy Markdown
Contributor

@agustibr agustibr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😃 Great work!!

Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work! 👏 👍

Copy link
Copy Markdown
Contributor

@Leusev Leusev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @slickepinne 👍
Although they have already done a very good review 😉 , I have added a couple of minor things

Thanks a lot for you work! 😄

@slickepinne slickepinne requested review from Leusev and leio10 August 13, 2020 15:13
leio10
leio10 previously approved these changes Aug 13, 2020
Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice changes, the code is getting better and better! 😍 👏 👏

@slickepinne slickepinne force-pushed the feature/add-elections-list-filter branch from 283eae4 to 11f462d Compare August 17, 2020 07:22
@leio10 leio10 self-requested a review August 17, 2020 10:55
@slickepinne
Copy link
Copy Markdown
Contributor Author

Hi @decidim/core, @decidim/product gave their OK for this PR so it's ready to get reviewed. 😊 Regarding the translations, I think it makes more sense to change them in the specific branch but let me know if you see it different. 😊

Copy link
Copy Markdown
Contributor

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @slickepinne, good job !

@tramuntanal tramuntanal merged commit 56d7319 into develop Aug 27, 2020
@tramuntanal tramuntanal deleted the feature/add-elections-list-filter branch August 27, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

See all the elections

6 participants