Add elections list filter and sorting#6386
Merged
tramuntanal merged 42 commits intodevelopfrom Aug 27, 2020
Merged
Conversation
4 tasks
agustibr
previously approved these changes
Aug 10, 2020
decidim-elections/app/controllers/concerns/decidim/elections/orderable.rb
Outdated
Show resolved
Hide resolved
decidim-elections/app/controllers/decidim/elections/elections_controller.rb
Outdated
Show resolved
Hide resolved
decidim-elections/app/views/decidim/elections/elections/_elections.html.erb
Outdated
Show resolved
Hide resolved
leio10
suggested changes
Aug 11, 2020
decidim-elections/app/assets/stylesheets/decidim/elections/focus/_evote.scss
Show resolved
Hide resolved
decidim-elections/app/assets/stylesheets/decidim/elections/focus/_focus.scss
Show resolved
Hide resolved
decidim-elections/app/assets/stylesheets/decidim/elections/focus/_focus.scss
Show resolved
Hide resolved
decidim-elections/app/assets/stylesheets/decidim/elections/focus/_focus.scss
Show resolved
Hide resolved
decidim-elections/app/assets/stylesheets/decidim/elections/focus/_focus.scss
Show resolved
Hide resolved
decidim-elections/app/controllers/decidim/elections/elections_controller.rb
Outdated
Show resolved
Hide resolved
decidim-elections/app/views/decidim/elections/elections/show.html.erb
Outdated
Show resolved
Hide resolved
decidim-elections/app/views/decidim/elections/elections/show.html.erb
Outdated
Show resolved
Hide resolved
decidim-elections/app/controllers/decidim/elections/elections_controller.rb
Outdated
Show resolved
Hide resolved
Leusev
suggested changes
Aug 13, 2020
Contributor
Leusev
left a comment
There was a problem hiding this comment.
Good job @slickepinne 👍
Although they have already done a very good review 😉 , I have added a couple of minor things
Thanks a lot for you work! 😄
decidim_app-design/app/views/public/partials/_focus_content_content_1.html.erb
Show resolved
Hide resolved
decidim_app-design/app/views/public/partials/_focus_content_content_confirm.html.erb
Show resolved
Hide resolved
decidim_app-design/app/views/public/partials/_focus_content_content_confirmed.html.erb
Show resolved
Hide resolved
decidim_app-design/app/views/public/partials/_focus_content_content_confirm.html.erb
Show resolved
Hide resolved
decidim_app-design/app/views/public/partials/_focus_content_content_confirmed.html.erb
Show resolved
Hide resolved
decidim_app-design/app/views/public/partials/_focus_content_content_encrypting.html.erb
Show resolved
Hide resolved
leio10
previously approved these changes
Aug 13, 2020
Contributor
leio10
left a comment
There was a problem hiding this comment.
very nice changes, the code is getting better and better! 😍 👏 👏
decidim-elections/app/controllers/decidim/elections/elections_controller.rb
Outdated
Show resolved
Hide resolved
90a1449 to
719e6f1
Compare
283eae4 to
11f462d
Compare
leio10
approved these changes
Aug 17, 2020
Contributor
Author
|
Hi @decidim/core, @decidim/product gave their OK for this PR so it's ready to get reviewed. 😊 Regarding the translations, I think it makes more sense to change them in the specific branch but let me know if you see it different. 😊 |
tramuntanal
approved these changes
Aug 27, 2020
Contributor
tramuntanal
left a comment
There was a problem hiding this comment.
LGTM @slickepinne, good job !
This was referenced Sep 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
For visitors, it should be possible to filter and sort elections depending on the elections' status:
active,upcomingorfinished. They can sort forrecentorolderelections. Also, the pagination filter is added.When only one
electionis given, the visitor gets redirected to theelectionpage.When there's no
active,upcomingor noneelection, the visitor sees a warning.📌 Related Issues
📋 Subtasks
election statuselectionelectionelectionsavailableelectionis given📷 Screenshots (optional)
When there's no filter selected,

recentis the default the order:When order for

older elections:No

active elections:Only one

active election(noall electionslink):Alert for

finished elections: