Backport "Apply migration of data in surveys legacy tables automatically" to v0.22#6303
Merged
tramuntanal merged 5 commits intorelease/0.22-stablefrom Jul 27, 2020
Conversation
ivan-mr
approved these changes
Jul 15, 2020
Leusev
approved these changes
Jul 16, 2020
Contributor
Leusev
left a comment
There was a problem hiding this comment.
Looks good for me, with the development_app exception @tramuntanal
Contributor
Author
|
Let's wait until we merge a definitive solution into |
Contributor
Author
|
This PR is ready for review again |
Leusev
reviewed
Jul 27, 2020
| end | ||
| end | ||
|
|
||
| def development_app? |
Contributor
Author
There was a problem hiding this comment.
nowhere... I required it in a previous implementation but when reworking the PR I forgot to remove it. I've just removed it now
Leusev
approved these changes
Jul 27, 2020
Contributor
Leusev
left a comment
There was a problem hiding this comment.
Looks good for me @tramuntanal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
As the original PR, this one fixes the migration of surveys' legacy tables to:
📌 Related Issues