Skip to content

Backport fixing performance degradation while answering surveys#6255

Merged
tramuntanal merged 2 commits into0.21-stablefrom
backport/survey-answering-performance
Jul 3, 2020
Merged

Backport fixing performance degradation while answering surveys#6255
tramuntanal merged 2 commits into0.21-stablefrom
backport/survey-answering-performance

Conversation

@microstudi
Copy link
Copy Markdown
Contributor

@microstudi microstudi commented Jun 30, 2020

🎩 What? Why?

This is a backport for #5819 for the 0.21 release.
As the 0.22 will be delayed a while, busy sites are suffering from a severe penalty performance without this fixed.

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG

@microstudi
Fix questionnaire answer method to avoid query model relationships (#…
107f522 
…5819)

* change answer method name to avoid query model relationships

* add changelog

* fix survey tests

* additional questionnaire spec fix

* update changelog

* update changelog
@microstudi
fix changelog
793ffda
@microstudi microstudi changed the title Backport surveys answering performance Backport performance degradation while answering surveys Jun 30, 2020
@microstudi microstudi added the backport Pull Requests that are a backport for a fixed bug label Jun 30, 2020
@microstudi microstudi requested review from Leusev and tramuntanal and removed request for Leusev June 30, 2020 15:51
@PierreJiji
Copy link
Copy Markdown

PierreJiji commented Jun 30, 2020 •
edited
Loading

Hi,
I am currently using version 20 of Decidim and i have a performance problem for the survey page when i do the test of performance, and i see that this problem has been solved in #5819 but its not available in the version 20 or 21
I need to be able to use this solution with version 21 at least.

thank you very much for your collaboration!

@microstudi
Copy link
Copy Markdown
Contributor Author

microstudi commented Jul 1, 2020

@tramuntanal @Leusev tests are passing, codecov is exactly the same but complaining, no clue why.

Leusev
Leusev approved these changes Jul 1, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Leusev Leusev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me @microstudi 👍
What do you think about codecov issue @tramuntanal ?

@tramuntanal
Copy link
Copy Markdown
Contributor

tramuntanal commented Jul 3, 2020

I see codecov/patch is ok @microstudi @Leusev

@mrcasals
Copy link
Copy Markdown
Contributor

mrcasals commented Jul 3, 2020

With the current PR title it seems like you're making the code less performance ("backport performance degradation").

I'd suggest adding "fix" somewhere to make it clearer! 😄

@microstudi microstudi changed the title Backport performance degradation while answering surveys Backport fixing performance degradation while answering surveys Jul 3, 2020
@microstudi
Copy link
Copy Markdown
Contributor Author

microstudi commented Jul 3, 2020

can we merge then @tramuntanal ?

@tramuntanal tramuntanal merged commit 71c1aa1 into 0.21-stable Jul 3, 2020
@tramuntanal tramuntanal deleted the backport/survey-answering-performance branch July 3, 2020 15:28
@microstudi microstudi mentioned this pull request Jul 23, 2020
Closed
13 tasks
@Quentinchampenois Quentinchampenois mentioned this pull request Aug 20, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tramuntanal tramuntanal Awaiting requested review from tramuntanal

1 more reviewer

@Leusev Leusev Leusev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport Pull Requests that are a backport for a fixed bug in-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@microstudi @PierreJiji @tramuntanal @mrcasals @Leusev