Skip to content

Fix participatory text newline absence#6158

Merged
jesusdb merged 4 commits intodevelopfrom
bugfix/participatory-text-whitespace
Jun 5, 2020
Merged

Fix participatory text newline absence#6158
jesusdb merged 4 commits intodevelopfrom
bugfix/participatory-text-whitespace

Conversation

@jesusdb
Copy link
Copy Markdown
Contributor

@jesusdb jesusdb commented Jun 5, 2020

🎩 What? Why?

The participatory text was showing itself without newlines when it should.
This PR fixes this by replacing the paragraph closing tags (</p>) with line feeds (\n) before stripping the tags.

📌 Related Issues

  • Fixes DECIDIM-140 (Jira)

📋 Subtasks

  • Add CHANGELOG entry

@jesusdb jesusdb marked this pull request as ready for review June 5, 2020 09:30
@jesusdb jesusdb requested review from Leusev and microstudi June 5, 2020 09:31
This is to solve a Rubocop offense.
Copy link
Copy Markdown
Contributor

@ivan-mr ivan-mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jesusdb jesusdb merged commit a60a206 into develop Jun 5, 2020
@jesusdb jesusdb deleted the bugfix/participatory-text-whitespace branch June 5, 2020 11:07
@jesusdb jesusdb restored the bugfix/participatory-text-whitespace branch June 8, 2020 14:08
@jesusdb jesusdb deleted the bugfix/participatory-text-whitespace branch June 8, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants