Backport to let components without step settings be added#6144
Merged
ivan-mr merged 4 commits into0.21-stablefrom Jun 3, 2020
Merged
Backport to let components without step settings be added#6144ivan-mr merged 4 commits into0.21-stablefrom
ivan-mr merged 4 commits into0.21-stablefrom
Conversation
* Let components without step settings be added * Add changelog * Add tests * New Crowdin translations (#5761) * New translations en.yml (French) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) Co-authored-by: Txus <me@txus.io> Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com> Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>
Member
Contributor
Author
|
Hi @andreslucena, this is because we're fixing the error from one of our clients. Is that ok?
About this, yes, thanks, I closed it. |
Leusev
suggested changes
Jun 3, 2020
Contributor
Leusev
left a comment
There was a problem hiding this comment.
Could you solve that changelog conflict please?
Thanks!
Contributor
Author
|
@Leusev sure! I'll just wait first for @andreslucena's feedback |
Member
Ok |
Leusev
approved these changes
Jun 3, 2020
ivan-mr
approved these changes
Jun 3, 2020
Contributor
ivan-mr
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This is a backport to fix an error raised when creating a sortition component if no setting is added.
📌 Related Issues