Skip to content

Mockup design for Complex Budgets flow#5874

Merged
leio10 merged 15 commits intofeat/complex-budgets-votingfrom
feature/pam2020/budgets-flow
Apr 3, 2020
Merged

Mockup design for Complex Budgets flow#5874
leio10 merged 15 commits intofeat/complex-budgets-votingfrom
feature/pam2020/budgets-flow

Conversation

@htmlboy
Copy link
Copy Markdown
Contributor

@htmlboy htmlboy commented Mar 19, 2020

🎩 What? Why?

Design proposal for #5709

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

📷 Screenshots (optional)

Description

@htmlboy htmlboy requested a review from agustibr March 19, 2020 15:56
Copy link
Copy Markdown
Contributor

@agustibr agustibr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some erblint issues you can auto-fix them running erblint -la -a from the project's root.
Also keep in mid that translations, other than english, are managed with crowdin https://github.com/decidim/decidim/blob/develop/CONTRIBUTING.md#do-you-want-to-improve-or-add-a-new-language-for-decidim, thanks.
😁

invited: Vous avez une invitation en attente, acceptez-la pour terminer la création de votre compte.
last_attempt: Vous avez encore une tentative avant que votre compte soit verrouillé.
locked: Ton compte est bloqué.
locked: Votre compte est bloqué.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translations, except English, are manged through Crowdin https://crowdin.com/project/decidim

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2020

Codecov Report

Merging #5874 into develop will decrease coverage by 1.41%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5874      +/-   ##
===========================================
- Coverage    97.29%   95.87%   -1.42%     
===========================================
  Files         2478     3450     +972     
  Lines        71311    97187   +25876     
===========================================
+ Hits         69379    93175   +23796     
- Misses        1932     4012    +2080
Impacted Files Coverage Δ
decidim-meetings/lib/decidim/meetings/engine.rb 90.62% <0%> (-1.32%) ⬇️
...eetings/app/cells/decidim/meetings/meeting_cell.rb 70.96% <0%> (-0.91%) ⬇️
.../decidim/participatory_processes/process_m_cell.rb 96.77% <0%> (-0.11%) ⬇️
...eetings/app/helpers/decidim/meetings/map_helper.rb 100% <0%> (ø) ⬆️
...ts/app/commands/decidim/comments/create_comment.rb 100% <0%> (ø) ⬆️
...pp/helpers/decidim/assemblies/assemblies_helper.rb 76.92% <0%> (ø) ⬆️
...omments/app/forms/decidim/comments/comment_form.rb 100% <0%> (ø) ⬆️
...ry_processes/participatory_processes_controller.rb 100% <0%> (ø) ⬆️
...m/verifications/confirm_user_authorization_spec.rb 100% <0%> (ø) ⬆️
...idim-comments/spec/commands/create_comment_spec.rb 100% <0%> (ø) ⬆️
... and 982 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11c979a...36021c6. Read the comment docs.

agustibr
agustibr previously approved these changes Mar 26, 2020
@andreslucena andreslucena changed the title Feature/pam2020/budgets flow Mockup design for Complex Budgets flow Mar 31, 2020
@leio10 leio10 changed the base branch from develop to feat/complex-budgets-voting April 3, 2020 10:50
@leio10 leio10 merged commit 13508fa into feat/complex-budgets-voting Apr 3, 2020
@leio10 leio10 deleted the feature/pam2020/budgets-flow branch April 3, 2020 10:55
@leio10 leio10 mentioned this pull request Apr 3, 2020
3 tasks
@agustibr agustibr restored the feature/pam2020/budgets-flow branch April 6, 2020 09:51
@ivan-mr ivan-mr deleted the feature/pam2020/budgets-flow branch April 7, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants