Manage conditions to hide or show questions in surveys by verarojman · Pull Request #5798 · decidim/decidim

verarojman · 2020-02-26T12:51:09Z

🎩 What? Why?

Add new "logic" feature to questionnaires, allowing for questions to have display conditions to determine whether they should be shown, depending on the answer to another question from the same questionnaire.

Condition types are:

Answered or Not answered (They check whether the question has been answered or not)
Equal or Not equal (They check whether the answer matches a given answer_option or not)
Includes text (It checks if answer contains given text, case-insensitively)

A condition can be mandatory or not. All mandatory conditions must be fulfilled for a question to be displayed. If no conditions are mandatory, the question will be displayed if any condition matches.

📌 Related Issues

Related to
- Metadecidim - Survey logic feature for Decidim Survey
- OpenSourcePolitics - Survey logic feature for Decidim Survey

📋 Subtasks

Add CHANGELOG entry
Add/modify seeds
Add tests

📷 Screenshots

Manage survey - Question with "includes text" condition

Manage survey - Question with multiple conditions

Public behaviour video demo:

…ecidim into feature/questionnaire-logic

verarojman · 2020-05-29T17:35:09Z

@jesusdb this method is covered and I just added extra specs to ensure that. Are we okay to merge? :)

jesusdb · 2020-06-03T11:01:39Z

Great! Now it seems to be covered, but it looks like there are others not covered? Could you please check the answer_option.rb and update_questionnaire.rb?

microstudi · 2020-06-04T17:39:51Z

@jesusdb these files should be covered now. Can you review this, thanks!

jesusdb · 2020-06-15T08:04:15Z

decidim-forms/app/views/decidim/forms/questionnaires/_answer.html.erb

@@ -1,10 +1,9 @@
-<% field_id = "questionnaire_answers_#{answer_idx}" %>
+<% field_id = "questionnaire_responses_#{answer_idx}" %>


One doubt; why changing from "answers" to "responses"?

questionnaire_responses_* is the correct id, I merged from develop and had to change it.

@jesusdb this may be related to this: #5819 we changed answers to responses to avoid default behavior of Rectify Forms loading answers unnecessarily and causing a heavy penalty performance regression.

jesusdb

Excellent work! I just left some little suggestions

decidim-forms/db/migrate/20200130194123_create_decidim_forms_display_conditions.rb

...forms/lib/decidim/forms/test/shared_examples/manage_questionnaires/add_display_conditions.rb

decidim-forms/lib/decidim/forms/test/shared_examples/manage_questionnaires/add_questions.rb

decidim-forms/lib/decidim/forms/test/shared_examples/manage_questionnaires/update_questions.rb

decidim-forms/spec/commands/decidim/forms/admin/update_questionnaire_spec.rb

decidim-forms/spec/models/decidim/forms/display_condition_spec.rb

Co-authored-by: Jesús Di Bari <61017625+jesusdb@users.noreply.github.com>

virgile-dev · 2020-06-18T15:12:11Z

Hey guys !
@verarojman thanks for the awesome work !
This PR is several months old, we've ordered it to Ivan and our client is showin sign of impatience as we promised it for march. I can see are close to the merge can you guys @jesusdb @tramuntanal can we make it happen before the end of next week ?
Thanks in advance !

jesusdb · 2020-06-26T11:07:17Z

@virgile-dev sorry for the delay! And thanks @verarojman, ready to merge!

PR superseded by #6241

verarojman added 30 commits January 31, 2020 14:18

Create QuestionCondition migration, model and spec

fb83566

Add validations and specs for QuestionCondition

c14382f

Specs for question_condition.fulfilled?

85e5a02

Spec for match condition type

3ff0cf8

Spec for match condition type

e8fa7fa

Merge branch 'feature/questionnaire-logic' of github.com:verarojman/d…

289bd43

…ecidim into feature/questionnaire-logic

Create QuestionConditionForm and its spec

4193a49

Add examples to QuestionConditionForm spec

50002e2

Rename model to more descriptive DisplayCondition

af68878

Update DisplayCondition form and spec

21c3c5a

Add display_conditions association to question

d248f2f

Create display_condition view elements and helpers

7de4cd7

Restructuring dynamic fields for display conditions

ecbe3c5

Add utility methods

7787569

Setup select tags

a9e1a05

Add question type in condition_question select

630de1b

Call url on condition question change

566f90f

Fetch json with answer_options from questionnaire form

10a8097

Load answer options into select

23e9a99

Load answer options only when question type isMultipleOption

9c820ab

Save display_conditions

a791827

Update display condition form spec

9bd1dde

Improve DisplayConditionForm validations

9849107

Fix question options for select

4d7b9a4

Match attribute names in disp. condition form to database fields

5e3a5f8

Load answer options from question

0602909

Select options from URL js component

588f419

Dynamic inputs for each display condition

fbedaa9

Filter condition types by condition question type

ad8f26a

Load saved condition question in select

5cacd00

jesusdb self-assigned this May 29, 2020

Add spec for forms admin application helper

6b9b9c2

verarojman and others added 2 commits June 1, 2020 11:43

Merge branch 'develop' into feature/survey-logic

bd97108

Merge branch 'develop' into feature/survey-logic

174a2b3

verarojman and others added 4 commits June 3, 2020 17:12

Merge branch 'develop' into feature/survey-logic

ad85f27

Merge branch 'develop' into feature/survey-logic

e95ce83

Add answer_option spec

0c77744

Add example for display conditions in update questionnaire spec

8c8d19f

jesusdb reviewed Jun 15, 2020

View reviewed changes

jesusdb suggested changes Jun 15, 2020

View reviewed changes

verarojman and others added 11 commits June 16, 2020 12:52

Use bigint for ids

6805ad6

Co-authored-by: Jesús Di Bari <61017625+jesusdb@users.noreply.github.com>

Use option for variable name in block

a84169a

Co-authored-by: Jesús Di Bari <61017625+jesusdb@users.noreply.github.com>

Use option for variable name in block

a541bef

Co-authored-by: Jesús Di Bari <61017625+jesusdb@users.noreply.github.com>

Use "element" for variable name in block

d8803ea

Co-authored-by: Jesús Di Bari <61017625+jesusdb@users.noreply.github.com>

Typographic suggestion fix 1

3f3849e

Co-authored-by: Jesús Di Bari <61017625+jesusdb@users.noreply.github.com>

Typographic suggestion fix 2

7131b4e

Co-authored-by: Jesús Di Bari <61017625+jesusdb@users.noreply.github.com>

Typographic suggestion fix 3

9b50967

Co-authored-by: Jesús Di Bari <61017625+jesusdb@users.noreply.github.com>

Typographic suggestion fix 4

f209fae

Co-authored-by: Jesús Di Bari <61017625+jesusdb@users.noreply.github.com>

Typographic suggestion fix 5

f8f6dd9

Co-authored-by: Jesús Di Bari <61017625+jesusdb@users.noreply.github.com>

Merge branch 'develop' into feature/survey-logic

5bef394

Clearer idx variable names in block

9914aab

jesusdb self-requested a review June 19, 2020 11:01

jesusdb mentioned this pull request Jun 26, 2020

Supersede "Manage conditions to hide or show questions in surveys" #6241

Merged

jesusdb closed this Jun 26, 2020

microstudi mentioned this pull request Jul 8, 2020

Temp/0.22 surveys Platoniq/decidim#26

Closed

		@@ -1,10 +1,9 @@
		<% field_id = "questionnaire_answers_#{answer_idx}" %>
		<% field_id = "questionnaire_responses_#{answer_idx}" %>

Uh oh!

Conversation

verarojman commented Feb 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎩 What? Why?

📌 Related Issues

📋 Subtasks

📷 Screenshots

Manage survey - Question with "includes text" condition

Manage survey - Question with multiple conditions

Public behaviour video demo:

Uh oh!

verarojman commented May 29, 2020

Uh oh!

jesusdb commented Jun 3, 2020

Uh oh!

microstudi commented Jun 4, 2020

Uh oh!

jesusdb Jun 15, 2020

Choose a reason for hiding this comment

Uh oh!

verarojman Jun 15, 2020

Choose a reason for hiding this comment

Uh oh!

microstudi Jun 15, 2020

Choose a reason for hiding this comment

Uh oh!

jesusdb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

virgile-dev commented Jun 18, 2020

Uh oh!

jesusdb commented Jun 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

verarojman commented Feb 26, 2020 •

edited

Loading