Skip to content

Enable user instead of deleting it if pending invitations exist#5740

Closed
tramuntanal wants to merge 7 commits intodevelopfrom
fix/previously_invited_users_are_deleted_when_registering
Closed

Enable user instead of deleting it if pending invitations exist#5740
tramuntanal wants to merge 7 commits intodevelopfrom
fix/previously_invited_users_are_deleted_when_registering

Conversation

@tramuntanal
Copy link
Copy Markdown
Contributor

🎩 What? Why?

When a pending invitation with the same email already exists, it is "upgraded" to a registered user and a confirmation email is sent.

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

📷 Screenshots (optional)

Description

@tramuntanal tramuntanal self-assigned this Feb 14, 2020
@sebgalProd
Copy link
Copy Markdown

Hello,
My decidim is on production and my system is blocked for some Amendments and private participants.

I am a beginner with rubys on rails and I do not understand certain subtleties. I'm going to make the modifications you made, but I don't have the files (was there a compilation, then deletion of the files?)

My question is:
how to resolve the concerns already present? (user delete or add missing data by hand to the database? but what data to submit?)
and
How to make your modifications on my server, knowing that I don't have the files?

Many thanks for your time!

@tramuntanal
Copy link
Copy Markdown
Contributor Author

Closing this PR in favour of 5803.

It turns out that changing the behavior of the registrations controller is not difficult, but then there are other use cases to take into account in when the user accepts the invitation after having registered, tacking these is out of scope for the current bugfix, e.g:

  • the admin re-sends an invitation to the already registered user
  • an impersonated user is promoting its account

@tramuntanal tramuntanal deleted the fix/previously_invited_users_are_deleted_when_registering branch February 27, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User previously invited are DELETED when registering

2 participants