Skip to content

Add assemblies participatory space specifications to the GraphQL API#5544

Merged
microstudi merged 13 commits intodecidim:masterfrom
Platoniq:api/assemblies
Jan 31, 2020
Merged

Add assemblies participatory space specifications to the GraphQL API#5544
microstudi merged 13 commits intodecidim:masterfrom
Platoniq:api/assemblies

Conversation

@davidbeig
Copy link
Copy Markdown
Contributor

@davidbeig davidbeig commented Dec 3, 2019

🎩 What? Why?

Add decidim-assemblies specification to the API.

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests

📷 Screenshots (optional)

image

@microstudi microstudi added the graphql-api Affects the GraphQL API label Dec 3, 2019
@microstudi microstudi self-assigned this Dec 3, 2019
tramuntanal
tramuntanal previously approved these changes Jan 16, 2020
Copy link
Copy Markdown
Contributor

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

@microstudi
Copy link
Copy Markdown
Contributor

rebased. fixed changelog.

tramuntanal
tramuntanal previously approved these changes Jan 17, 2020
@microstudi microstudi self-requested a review January 17, 2020 15:29
Copy link
Copy Markdown
Contributor

@microstudi microstudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some refactorings after the addition of AssemblyTypes. Blocking merge until done

microstudi
microstudi previously approved these changes Jan 31, 2020
Copy link
Copy Markdown
Contributor

@microstudi microstudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assemblies Type are now included. It should be ready to review

tramuntanal
tramuntanal previously approved these changes Jan 31, 2020
@microstudi microstudi changed the title API/Assemblies Add assemblies participatory space specifications to the GraphQL API Jan 31, 2020
@microstudi microstudi merged commit ebd81d1 into decidim:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graphql-api Affects the GraphQL API in-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants