Skip to content

fix wrong check of avatar_url in /oauth/me 0.15 backport (#4917)#4918

Merged
oriolgual merged 1 commit intodecidim:0.15-stablefrom
Platoniq:0.15-stable
Mar 1, 2019
Merged

fix wrong check of avatar_url in /oauth/me 0.15 backport (#4917)#4918
oriolgual merged 1 commit intodecidim:0.15-stablefrom
Platoniq:0.15-stable

Conversation

@microstudi
Copy link
Copy Markdown
Contributor

  • fix wrong check of avatar_url in /oauth/me controller that leads to a 500 error

In Decidim intallations configured to use external services as file provider
(such as AWS-S3), if a user has an avatar cannot authenticate using the builtin
OAuth server due an error checking the url in the credentials_controller

  • fix rubocop complain

  • [ci_skip] Changelog fix entry

🎩 What? Why?

📌 Related Issues

  • Related to #?
  • Fixes #?

📋 Subtasks

  • Add CHANGELOG entry
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

📷 Screenshots (optional)

Description

…ecidim#4917)

* fix wrong check of avatar_url in /oauth/me controller that leads to a 500 error

In Decidim intallations configured to use external services as file provider
(such as AWS-S3), if a user has an avatar cannot authenticate using the builtin
OAuth server due an error checking the url in the credentials_controller

* fix rubocop complain

* [ci_skip] Changelog fix entry
@oriolgual oriolgual merged commit 45a62d4 into decidim:0.15-stable Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants