[FIX] Use simple_format when rendering Participatory Text.#4782
Merged
[FIX] Use simple_format when rendering Participatory Text.#4782
simple_format when rendering Participatory Text.#4782Conversation
isaacmg410
reviewed
Jan 24, 2019
| def body | ||
| return unless model.participatory_text_level == "article" | ||
| present(model).body | ||
| simple_format present(model).body(links: true) |
Contributor
There was a problem hiding this comment.
Would not it be better to use the decidim_sanitize method instead of the simple_format?
Contributor
Author
There was a problem hiding this comment.
Yeah! But both should be applied, one after the other.
Contributor
Author
|
Hi @decidim/lot-core codeclimate/diff-coverage has not executed. Can you force it to re-run? I don't have permissions. |
Contributor
|
I don't see a way to re-run it @tramuntanal, although we can by pass it, don't worry. |
…tory text public view.
0d05126 to
1d37541
Compare
4 tasks
isaacmg410
approved these changes
Jan 28, 2019
oriolgual
approved these changes
Jan 28, 2019
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Public view of Participatory Text is not preserving new lines.
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)
First paragraph is multiline now:
