MetricResolver filtering corrected comparison between symbol and string#4733
Merged
MetricResolver filtering corrected comparison between symbol and string#4733
Conversation
Contributor
Author
|
@decidim/lot-core This is a quick fix for metrics. After merging this, I have to create another backport PRs. |
mrcasals
previously approved these changes
Jan 7, 2019
mrcasals
approved these changes
Jan 8, 2019
Contributor
|
@MarcReniu merged! Can you work on the backport please? 😄 |
Contributor
Author
|
Yes, only for |
1 task
Contributor
|
@MarcReniu yes! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
MetricResolver was not filtering results by
ParticipatorySpace, even when values passed by parameter. This correction solves it.📋 Subtasks
CHANGELOGentry