Skip to content

Profile minicard#4465

Merged
mrcasals merged 12 commits intomasterfrom
4346-minicard
Nov 14, 2018
Merged

Profile minicard#4465
mrcasals merged 12 commits intomasterfrom
4346-minicard

Conversation

@Crashillo
Copy link
Copy Markdown
Contributor

🎩 What? Why?

It shows a minicard on hover the author name in a card. It contains extra info about the registered user.

📌 Related Issues

📷 Screenshots (optional)

imagen

@mrcasals
Copy link
Copy Markdown
Contributor

@Crashillo looks like I can't click on the links on the tooltip, it disappears. Users should be able to interact with them, as per #4346 (comment) (see thumbs up by @decidim/product)

@Crashillo
Copy link
Copy Markdown
Contributor Author

You can. First, you should click the author name, that action makes the tooltip to keep visible. Then, you're able to interact with the inner content.
The thing here is: Should we disable rendering the minicard on hover action? (just leave on click action) It's just a property, so technically is straightforward.
IMHO, I'd disable hover action, because is causing the missunderstanding you had.

@mrcasals
Copy link
Copy Markdown
Contributor

@decidim/product can you chime in here please? ^

@carolromero
Copy link
Copy Markdown
Member

+1, let's proceed with @Crashillo's suggestion.

@furilo
Copy link
Copy Markdown
Contributor

furilo commented Nov 13, 2018 via email

@Crashillo
Copy link
Copy Markdown
Contributor Author

Crashillo commented Nov 13, 2018

I've just included a hook to keep the tooltip open while the cursor is over the tooltip content

@mrcasals
Copy link
Copy Markdown
Contributor

@Crashillo looking good! For what I understand, this design applies for both users and user groups, and when the author is an organization we don't show any tooltip, right? /cc @furilo

@mrcasals mrcasals merged commit 78ea5cc into master Nov 14, 2018
@ghost ghost removed the status: Ready-to-dev label Nov 14, 2018
@mrcasals mrcasals deleted the 4346-minicard branch November 14, 2018 07:57
@carolromero carolromero mentioned this pull request Feb 9, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants