Skip to content

SMS verification workflow#4429

Merged
oriolgual merged 6 commits intomasterfrom
feature/sms-verification
Nov 7, 2018
Merged

SMS verification workflow#4429
oriolgual merged 6 commits intomasterfrom
feature/sms-verification

Conversation

@oriolgual
Copy link
Copy Markdown
Contributor

@oriolgual oriolgual commented Nov 6, 2018

🎩 What? Why?

Adds a new verification workflow to verify users by sending and SMS. Each decidim app will just need to implement a class to send the SMS.

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add documentation regarding the feature
  • Add tests

@oriolgual oriolgual requested a review from josepjaume November 6, 2018 14:36
@ghost ghost assigned oriolgual Nov 6, 2018
@ghost ghost added the status: WIP label Nov 6, 2018
@oriolgual oriolgual force-pushed the feature/sms-verification branch from 494fb84 to 49b5fbd Compare November 6, 2018 14:39
@ghost ghost added the status: WIP label Nov 6, 2018
@oriolgual oriolgual force-pushed the feature/sms-verification branch from 49b5fbd to 9a5d23d Compare November 6, 2018 14:41
@oriolgual oriolgual force-pushed the feature/sms-verification branch from 9a5d23d to 81b947a Compare November 6, 2018 14:45
@ghost ghost added the status: WIP label Nov 6, 2018
josepjaume
josepjaume previously approved these changes Nov 6, 2018
@ghost ghost added the status: WIP label Nov 7, 2018
Copy link
Copy Markdown
Contributor

@josepjaume josepjaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Congratulations!

@oriolgual oriolgual merged commit 8ab8a5c into master Nov 7, 2018
@oriolgual oriolgual deleted the feature/sms-verification branch November 7, 2018 12:16
@oriolgual oriolgual added this to the CDP6 milestone Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants