Skip to content

Apply new conference design#4194

Merged
mrcasals merged 23 commits intomasterfrom
apply_new_conference_design
Oct 15, 2018
Merged

Apply new conference design#4194
mrcasals merged 23 commits intomasterfrom
apply_new_conference_design

Conversation

@isaacmg410
Copy link
Copy Markdown
Contributor

@isaacmg410 isaacmg410 commented Sep 27, 2018

🎩 What? Why?

This PR applies the new design #3843 to the MVP of conferences #3743 previously developed and that is already merged

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Apply the new design
  • modify factores
  • change some tests

📷 Screenshots (optional)

Description

@ghost ghost assigned isaacmg410 Sep 27, 2018
@ghost ghost added the status: WIP label Sep 27, 2018
@isaacmg410
Copy link
Copy Markdown
Contributor Author

@decidim/lot-core There is one meeting test failing, I didn't modify this file/spec and I don't undersatand why is failing. Can anyone help me, please?

@mrcasals
Copy link
Copy Markdown
Contributor

mrcasals commented Oct 8, 2018

Failed job was https://circleci.com/gh/decidim/decidim/159300 I've rescheduled to see if it was a flaky.

@isaacmg410
Copy link
Copy Markdown
Contributor Author

@mrcasals it seems that is not a flaky test, no?

@mrcasals
Copy link
Copy Markdown
Contributor

mrcasals commented Oct 8, 2018

@isaacmg410 the errors are different

@isaacmg410 isaacmg410 mentioned this pull request Oct 11, 2018
3 tasks
@isaacmg410
Copy link
Copy Markdown
Contributor Author

@decidim/lot-core ready to review :)

@mrcasals mrcasals merged commit 3c5d4db into master Oct 15, 2018
@mrcasals mrcasals deleted the apply_new_conference_design branch March 4, 2019 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants