Merged
Conversation
added 12 commits
September 27, 2018 14:32
Contributor
Author
|
@decidim/lot-core There is one meeting test failing, I didn't modify this file/spec and I don't undersatand why is failing. Can anyone help me, please? |
Contributor
|
Failed job was https://circleci.com/gh/decidim/decidim/159300 I've rescheduled to see if it was a flaky. |
Contributor
Author
|
@mrcasals it seems that is not a flaky test, no? |
Contributor
|
@isaacmg410 the errors are different |
added 7 commits
October 9, 2018 12:27
3 tasks
Contributor
Author
|
@decidim/lot-core ready to review :) |
mrcasals
approved these changes
Oct 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR applies the new design #3843 to the MVP of conferences #3743 previously developed and that is already merged
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)