Skip to content

Single process on home/processes#3776

Merged
mrcasals merged 8 commits intomasterfrom
3640-adaptative-single-card-home
Jul 31, 2018
Merged

Single process on home/processes#3776
mrcasals merged 8 commits intomasterfrom
3640-adaptative-single-card-home

Conversation

@Crashillo
Copy link
Copy Markdown
Contributor

🎩 What? Why?

Adds new views about how it looks like when a platform has only one process. It replaces the common card with a full-card, instead.

📌 Related Issues

📷 Screenshots (optional)

Home
imagen

Processes
imagen

@mrcasals
Copy link
Copy Markdown
Contributor

mrcasals commented Jul 4, 2018

@Crashillo I think the issue was only supposed to affect the homepage, not the list of processes. Otherwise, for consistency I think we'd need to update all the other grid lists (proposals, meetings, etc)...

@Crashillo
Copy link
Copy Markdown
Contributor Author

Let @decidim/product decide about it, but in anyway, it's something to do when integrating, render one card or another based on filter length.
The views have been duplicated, so in design app you may compare both.

@arnaumonty
Copy link
Copy Markdown
Member

@Crashillo we just apply this on the home page, not in the processes page.

@ghost ghost added status: WIP and removed status: Ready-to-dev labels Jul 9, 2018
@Crashillo
Copy link
Copy Markdown
Contributor Author

I've removed those templates which no longer apply.

@oriolgual
Copy link
Copy Markdown
Contributor

@Crashillo is this also ready to be merged?

@Crashillo
Copy link
Copy Markdown
Contributor Author

Same as previous, it concerns only to the design-app. It's done.

mrcasals
mrcasals previously approved these changes Jul 31, 2018
@mrcasals
Copy link
Copy Markdown
Contributor

@Crashillo there are some conflicts, can you fix them so we can merge this? 😄

@oriolgual
Copy link
Copy Markdown
Contributor

@Crashillo could you please review the linter errors?

@Crashillo
Copy link
Copy Markdown
Contributor Author

Crashillo commented Jul 31, 2018

Hmmm, the merge wasn't done properly. I've fixed it, let's wait for the tests.

@mrcasals
Copy link
Copy Markdown
Contributor

Tests are green, merging!

@mrcasals mrcasals merged commit ff5ce6e into master Jul 31, 2018
@mrcasals mrcasals deleted the 3640-adaptative-single-card-home branch July 31, 2018 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants