Skip to content

Feature/2589 search engine mvp#3548

Closed
tramuntanal wants to merge 133 commits intomasterfrom
feature/2589-search_engine_MVP
Closed

Feature/2589 search engine mvp#3548
tramuntanal wants to merge 133 commits intomasterfrom
feature/2589-search_engine_MVP

Conversation

@tramuntanal
Copy link
Copy Markdown
Contributor

@tramuntanal tramuntanal commented May 30, 2018

🎩 What? Why?

PR: #3042 has been compromised because a set of last commits have disappeared. We're reconstructing the history in this PR's branch from one of our local machines.

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests

Oliver Valls and others added 30 commits February 21, 2018 15:34
[WIP] Add pg_search gem.
d4e9d02
[WIP] Initial SearchableRsrc artifacts.
6d1b35a
Rubocop corrections.
c573ffa
Fix bad merge.
4815a51
[WIP] Specs for SearchController.
cafd3c2
@agustibr
Merge branch 'master' into feature/2589-Search-search_engine_API
e8e2f60
Introduce Search command.
968b7fd
Merge branch 'feature/2589-Search-search_engine_API' of https://githu…
6453829 
…b.com/decidim/decidim into feature/2589-Search-search_engine_API
@agustibr
[WIP] top bar search, results page
a001c25
Apply Search command into SearchController.
36c4d02
Implicit filter by tenant.
45849d5
@agustibr
[WIP] search results page
8db1829
@agustibr
Merge branch 'feature/2589-Search-search_engine_API' of github.com:de…
6c26c2e 
…cidim/decidim into feature/2589-Search-search_engine_API
Filtering by Model type.
83818f9
Merge branch 'feature/2589-Search-search_engine_API' of https://githu…
7a62d26 
…b.com/decidim/decidim into feature/2589-Search-search_engine_API
Filtering by scope.
7a28d78
Make Meetings Searchable.
04bad27
Rubocop corrections.
64b873b
[DOC] Document Searchable methods.
56082dc
Rubocop autocorrections.
9a8e8a0
Merge branch 'master' into feature/2589-Search-search_engine_API
12b8b45
[REFACTOR] Ignore Search filters when values are blank.
6ec95fb
Merge branch 'master' into feature/2589-Search-search_engine_API
6b5dfbc
[FEATURE] Apply locale filtering to search.
0f8e6f5
[REFACTOR] Use declarative way to map Resource <-> SearchRsrc fields,…
79bd53f 
… instead of forcing to override abstract method.
Merge branch 'master' into feature/2589-Search-search_engine_API
99c2003
[REFACTOR] Use 'component' which is the new name for 'fetaure'.
bd542db
Added SearchableRsrc uniqueness for locale and resource.
1ef41a4
Merge branch 'master' into feature/2589-Search-search_engine_API
b5fd950
[I18N] Normalize locales.
41cc7a2
Oliver Valls and others added 18 commits May 18, 2018 17:45
[TEST] Added meetings and proposals search specs.
90001d4
[FIX] Mispelling rsrc -> resouce.
f731287
[REFACTOR] Make rubocop happy by using be_positive.
9b52dc3
[TEST] Remove double class and use DummyResource instead to avoid col…
9eee4a1 
…laterals as this class may indirectly reapear in further tests.
[TEST] Remove DummyResource from Searchable.searchable_resources afte…
02fb520 
…r test.
Merge branch 'master' into feature/2589-Search-search_engine_API
0809045
[FIX] Replace pending renamings.
5934d41
[REFACTOR|TEST] Make DummyResouce explicitly Searchable to avoid coll…
094fe67 
…ateral efects of including Searchable to it inside a test.
Rubocopify.
0265a9c
[TEST] Update specs to take care of nil scope.
8d1650a
@agustibr
Merge branch 'master' into feature/2589-Search-search_engine_API
4625b88
@agustibr
added card label to results page
90e7d13
@agustibr
fix failing tests
844f129
[TEST] Remove useless test.
6d5654d
[TEST] Sort code for readability.
fbd4e9b
Merge branch 'master' into feature/2589-Search-search_engine_API
9f773b2
@tramuntanal
Merge branch 'master' into feature/2589-Search-search_engine_API
5caecf7
@agustibr
Merge branch 'master' into feature/2589-Search-search_engine_API
ca398d4
@ghost ghost assigned tramuntanal May 30, 2018
@ghost ghost added the status: WIP label May 30, 2018
@tramuntanal
Copy link
Copy Markdown
Contributor Author

tramuntanal commented May 30, 2018

@decidim/lot-core same generators problem here.
How did you solved this in master? We should manually solve this here because we suspect that you pushed --hard into PR 3531 removing branch own history.

@deivid-rodriguez
Copy link
Copy Markdown
Contributor

deivid-rodriguez commented May 30, 2018

Try something, squash all the diff into one commit and force push to this cloned branch.

@deivid-rodriguez
Copy link
Copy Markdown
Contributor

deivid-rodriguez commented May 30, 2018

My suspicion is that circle is somehow caching a bad status result from an old state (I see codecov checks in this branch :/). I think fresh commit sha1's will help.

@tramuntanal tramuntanal mentioned this pull request May 31, 2018
Closed
2 tasks
@oriolgual
Copy link
Copy Markdown
Contributor

oriolgual commented May 31, 2018

@tramuntanal I just merged master to your previous PR to solve the generators issue, I didn't push force.

@mrcasals
Copy link
Copy Markdown
Contributor

mrcasals commented May 31, 2018

@tramuntanal we didn't solve this on master because we never had this issue before. This issue has only been detected in PRs by your team.

@oriolgual
Copy link
Copy Markdown
Contributor

oriolgual commented May 31, 2018

Also, this branch doesn't seem to be up-to-date with current master

@josepjaume josepjaume closed this Jun 6, 2018
@ghost ghost removed the status: WIP label Jun 6, 2018
@josepjaume josepjaume deleted the feature/2589-search_engine_MVP branch June 6, 2018 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@tramuntanal tramuntanal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tramuntanal @deivid-rodriguez @oriolgual @mrcasals @josepjaume @agustibr