Instead of this, what about moving the T&C content to a field to the organization, instead of using a page?

@mrcasals Yes I thought about it, but it seemed to me a lot of changes to do in little time. And the issue references all StaticPages, in this case notable changes is only actionable within the ToS edit form but could be applied to any StaticPage (with some changes).

Who judges when a change is important? What happens if an admin changes the ToS and doesn't check the checkbox?

Apart from moving this to an attribute on Decidim::Organization, I think users should be notified every time the ToS are changed. The "Notable Change" thing would only make sense for the ToS, which means we're using the wrong approach here (that's why I say we should move it to an attribute to the organization).

@decidim/product can you chime in here please? Specifically @andreslucena, who's been working on GRPD issues.

@mrcasals I answer your questions

Who judges when a change is important?

An Admin user

What happens if an admin changes the ToS and doesn't check the checkbox?

Maybe the administrator is fixing a misspelling, and doesn't need to annouce it as a TOS update.
But in the case that forgets to check it, she could go back to the edit screen and check the checkbox.

I still feel it's very easy to miss this check, and we're using the wrong approach here. An ill-intended admin could check the ToS, saying you're giving your soul to the organization, and not checking the checkbox.

The other day we were talking about the ToS page and we agreed that the current approach is far from good. If theses changes are necessary, I'd highly encourage moving the ToS text to a field at the organization instead of keeping the current approach.

@decidim/lot-core Sorry I'm always the PIA but I think your comments should be in a new issue because this task solves the GDPR compliance as requested by @decidim/product.

If you think this should be refactored to other workflows or views it ought to be treated as an improvement in metadecidim. We even think that your proposal is a great idea but out of our scope here.

I guess that's fair @tramuntanal, we'll tackle this in another PR.

👍

It's out of scope more changes on TOS dynamic. Let's keep it simpler for the moment.

About the discussion of TOS on a given field, I prefer as it's right now (as a page), so we can leverage on some features of it - like WYSIWYG editor, and on the future being able to upload images and have this kind of contents: http://www.barcelona.cat/ca/avis-legal

If the idea is having it as a field but also having a WYSIWYG editor, then it's OK by me also

@agustibr can you rebase/update this from master to fix the CI errors?

Ok @andreslucena

@oriolgual yes I'll update the branch

@decidim/lot-core CI checks passed! can you review the PR

Thanks 👏