Skip to content

Fix erblint found errors#3291

Merged
mrcasals merged 2 commits intomasterfrom
fix-erblint-found-errors
Apr 26, 2018
Merged

Fix erblint found errors#3291
mrcasals merged 2 commits intomasterfrom
fix-erblint-found-errors

Conversation

@agustibr
Copy link
Copy Markdown
Contributor

🎩 What? Why?

erb_lint errors where not detected in master, updating the erb_lint gem solves the issue.

  • fixes erb_lint version
  • fixes offending files

📌 Related Issues

  • Related to none

📋 Subtasks

  • Add CHANGELOG entry

📷 Screenshots (optional)

@mrcasals
Copy link
Copy Markdown
Contributor

master started detecting this errors after updating the erb_lint version to 0.0.24

@agustibr agustibr mentioned this pull request Apr 26, 2018
1 task
@tramuntanal
Copy link
Copy Markdown
Contributor

@decidim/lot-core this PR is ready to be merged 😀

@mrcasals mrcasals merged commit e00f620 into master Apr 26, 2018
@mrcasals mrcasals deleted the fix-erblint-found-errors branch April 26, 2018 12:11
@mrcasals
Copy link
Copy Markdown
Contributor

Thanks @agustibr for taking the time to fix this! 😄

@agustibr
Copy link
Copy Markdown
Contributor Author

:bowtie:

@josepjaume
Copy link
Copy Markdown
Contributor

Thanks so much! I aprecciate you've taken the time to fix this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants