Fine grained permissions: consultations#3236
Merged
mrcasals merged 18 commits intofine-grained-permissions-adminfrom Apr 17, 2018
Merged
Fine grained permissions: consultations#3236mrcasals merged 18 commits intofine-grained-permissions-adminfrom
mrcasals merged 18 commits intofine-grained-permissions-adminfrom
Conversation
Once the permission was granted, we were granting it for all spaces. Now we fetch the space access for the given space.
4a380d7 to
28fe7ef
Compare
josepjaume
reviewed
Apr 16, 2018
| when :create, :read, :publish | ||
| allow! | ||
| when :update, :destroy, :preview | ||
| toggle_allow(consultation.present?) |
Contributor
There was a problem hiding this comment.
Sorry to ask (I know this API was probably introduced in another PR) but what does toggle_allow do, exactly? It sounds a bit confusing / misleading.
Contributor
Author
There was a problem hiding this comment.
Can be changed in #3137 if needed. If the condition evaluates to true, it calls allow! on the permission, otherwise it calls disallow! on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Fixes the consultations specs by moving it to the permissions system.
Note that this PR is against #3137 instead of
master.📌 Related Issues
📋 Subtasks
None