Merged
Conversation
|
@josepjaume, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mrcasals and @oriolgual to be potential reviewers. |
Contributor
|
@josepjaume looks like rectify 0.8 adds a Should we use this PR to use this new method, or schedule it in the backlog? |
mrcasals
approved these changes
Dec 8, 2016
Contributor
Author
|
Nice! I'd merge this and schedule that modification in the backlog, as we're updating other things as well. |
Current coverage is 96.96% (diff: 100%)@@ master #317 diff @@
==========================================
Files 362 362
Lines 6165 6165
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 5978 5978
Misses 187 187
Partials 0 0
|
beagleknight
approved these changes
Dec 9, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Because: Why not?
📌 Related Issues
None
📋 Subtasks
None
📷 Screenshots (optional)
None
👻 GIF