Skip to content

Update dependencies#317

Merged
josepjaume merged 1 commit intomasterfrom
feature/update_dependencies
Dec 9, 2016
Merged

Update dependencies#317
josepjaume merged 1 commit intomasterfrom
feature/update_dependencies

Conversation

@josepjaume
Copy link
Copy Markdown
Contributor

🎩 What? Why?

Because: Why not?

📌 Related Issues

None

📋 Subtasks

None

📷 Screenshots (optional)

None

👻 GIF

@mention-bot
Copy link
Copy Markdown

@josepjaume, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mrcasals and @oriolgual to be potential reviewers.

@mrcasals
Copy link
Copy Markdown
Contributor

mrcasals commented Dec 8, 2016

@josepjaume looks like rectify 0.8 adds a with_context instance method that works similar to what we do in our form_factory:

andypike/rectify@dd22080

Should we use this PR to use this new method, or schedule it in the backlog?

@josepjaume
Copy link
Copy Markdown
Contributor Author

Nice! I'd merge this and schedule that modification in the backlog, as we're updating other things as well.

@codecov-io
Copy link
Copy Markdown

Current coverage is 96.96% (diff: 100%)

Merging #317 into master will not change coverage

@@             master       #317   diff @@
==========================================
  Files           362        362          
  Lines          6165       6165          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           5978       5978          
  Misses          187        187          
  Partials          0          0          

Powered by Codecov. Last update 26b56cb...0343dc5

@josepjaume josepjaume merged commit 6fb1b61 into master Dec 9, 2016
@josepjaume josepjaume deleted the feature/update_dependencies branch December 9, 2016 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants