Closed
Conversation
mrcasals
approved these changes
Mar 16, 2018
Contributor
|
Loving the |
Contributor
|
Can you explain the problems a bit? I'm curious. |
Contributor
|
Example of a failing job: https://circleci.com/gh/decidim/decidim/70890 |
Contributor
|
Well, those lines did exactly what I expect them to: detect the same problem being introduced again. My bet is that it was introduced here. |
Codecov Report
@@ Coverage Diff @@
## master #3020 +/- ##
=======================================
Coverage 98.67% 98.67%
=======================================
Files 1698 1698
Lines 40500 40500
=======================================
Hits 39964 39964
Misses 536 536 |
Contributor
|
So it looks like not related actually... Let me have a closer look. |
Contributor
|
Found the culprit! See #3021. |
Contributor
Author
|
Closing in favor of #3021 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
It seems that the changes made at #2933 are causing some problems, so I'm reverting the affected part.
📌 Related Issues