Skip to content

Participatory Space Resourceable between Assemblies and ParticipatoryProcesses #2851

Merged
mrcasals merged 20 commits intomasterfrom
2709_MVP_participatory_space_resourceable
Mar 15, 2018
Merged

Participatory Space Resourceable between Assemblies and ParticipatoryProcesses #2851
mrcasals merged 20 commits intomasterfrom
2709_MVP_participatory_space_resourceable

Conversation

@isaacmg410
Copy link
Copy Markdown
Contributor

@isaacmg410 isaacmg410 commented Feb 28, 2018

🎩 What? Why?

Apply new system to link assemblies with participatory processes.

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • ParticipatorySpaceLink model
  • ParticipatorySpaceResourceable Concern
  • link Assemblies to Participatory prcesses
  • Tests

@ghost ghost assigned isaacmg410 Feb 28, 2018
@ghost ghost added the in-progress label Feb 28, 2018
@isaacmg410
Copy link
Copy Markdown
Contributor Author

@oriolgual @decidim/lot-core can you pre- review the new system for link Assembly and ParticipatorySpace.?

@oriolgual
Copy link
Copy Markdown
Contributor

@isaacmg410 the problem with the current implementation is that Assemblies is still depending on ParticipatoryProcesses (since the constant ParticipatoryProcess is used in the assemblies module).

@oriolgual
Copy link
Copy Markdown
Contributor

oriolgual commented Feb 28, 2018

You could use something like

spaces = Decidim.participatory_space_manifests.flat_map do |manifest|
  manifest.participatory_spaces.call(current_organization)
end

@isaacmg410
Copy link
Copy Markdown
Contributor Author

isaacmg410 commented Feb 28, 2018

@oriolgual is there any way to filter the participatory_space_manifests by their type, returning only the processeS?
something like this will work? Decidim.find_participatory_space_manifest(:participatory_processes).participatory_spaces.call(current_organization)

@oriolgual
Copy link
Copy Markdown
Contributor

I'm afraid there's no way right now but it could be easily extended!

@isaacmg410 isaacmg410 force-pushed the 2709_MVP_participatory_space_resourceable branch from 80a7083 to e80479d Compare March 2, 2018 11:35
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 2, 2018

Codecov Report

Merging #2851 into master will decrease coverage by 0.03%.
The diff coverage is 82.75%.

@@            Coverage Diff             @@
##           master    #2851      +/-   ##
==========================================
- Coverage   98.73%   98.69%   -0.04%     
==========================================
  Files        1670     1674       +4     
  Lines       39731    39817      +86     
==========================================
+ Hits        39227    39298      +71     
- Misses        504      519      +15

@isaacmg410 isaacmg410 changed the title [WIP] Participatory Space Resourceable between Assemblies and ParticipatoryProcesses Participatory Space Resourceable between Assemblies and ParticipatoryProcesses Mar 5, 2018
@isaacmg410
Copy link
Copy Markdown
Contributor Author

@decidim/lot-core can you take a look into this please. 😀

@carolromero carolromero mentioned this pull request Mar 12, 2018
6 tasks
# Public: A formatted collection of ParticipatoryProcesses to be used
# in forms.
# # Public: A formatted collection of ParticipatoryProcesses selected on
# # Assemblies to be used in forms.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These docs have a weird format


module Decidim
# A concern with the features needed when you want a model to be able to create
# links from it to another resource.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add docs with the difference between this concern and Decidim::Resourceable?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrcasals Do you mean creating a file inside the /docs folder?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, just improve the docs in this file!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@isaacmg410
Copy link
Copy Markdown
Contributor Author

@decidim/lot-core Can you review it again?

@mrcasals mrcasals merged commit 8b8ae2c into master Mar 15, 2018
@mrcasals mrcasals deleted the 2709_MVP_participatory_space_resourceable branch March 15, 2018 08:54
@ghost ghost removed the in-review label Mar 15, 2018
@mrcasals mrcasals mentioned this pull request Mar 15, 2018
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants