Add proposals to process and process group home#2817
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2817 +/- ##
==========================================
+ Coverage 98.87% 98.87% +<.01%
==========================================
Files 1604 1606 +2
Lines 37881 37936 +55
==========================================
+ Hits 37453 37508 +55
Misses 428 428 |
Contributor
Author
|
@decidim/lot-core Ready to review! |
mrcasals
reviewed
Feb 26, 2018
| # Returns an HTML safe String. | ||
| def render_participatory_processes_hook(hook_name) | ||
| Decidim::ParticipatoryProcesses.view_hooks.render(hook_name, self) | ||
| Decidim::ParticipatoryProcesses.view_hooks.render(hook_name, deep_dup) |
Contributor
There was a problem hiding this comment.
Can you improve the docs to explain why we need to send the deep_copy? I know it's on the public docs/ folder, but I think it's worth it having it here too 😄
mrcasals
approved these changes
Feb 26, 2018
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Show random proposals in process/process group home
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots