Merged
Conversation
Contributor
|
@Crashillo this PR has a failing test @decidim/lot-core we need this PR accepted to continue with the Search engine MVP · Issue #2707 · decidim/decidim |
Contributor
Author
|
You mean |
Contributor
|
I'm rerunning the job, see if it is solved. |
Codecov Report
@@ Coverage Diff @@
## master #2765 +/- ##
==========================================
+ Coverage 98.85% 98.86% +<.01%
==========================================
Files 1534 1534
Lines 36091 36091
==========================================
+ Hits 35679 35680 +1
+ Misses 412 411 -1 |
oriolgual
approved these changes
Feb 21, 2018
josepjaume
approved these changes
Feb 21, 2018
Contributor
|
🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Design of the top header search box.
IMPORTANT It does not contain the home page search.
📌 Related Issues
📷 Screenshots (optional)
Desktop:
Mobile:
