Conversation
Codecov Report
@@ Coverage Diff @@
## master #2440 +/- ##
=======================================
Coverage 98.84% 98.84%
=======================================
Files 1446 1446
Lines 33973 33973
=======================================
Hits 33582 33582
Misses 391 391 |
|
Hi! Not sure how can we implement this, as a process can have many components and any component several call to actions. Have you thought about an admin interface for this? |
|
I've edited the description of this PR to point to decidim-archive/design#161 instead of #161 |
@josepjaume like other configurable call to action buttons on Decidim, can we just not add a local address for the active component? |
josepjaume
left a comment
There was a problem hiding this comment.
Looks ok to me! Does this require adapting any currently existing markup?
|
It does. Currently there are two templates quite similar |
|
Well, what I meant is "do I need to adapt the currently existing markup or the UI will break"? We don't have a way on the admin UI to actually set an action for the button, so we won't show it for the moment. |
|
@josepjaume not sure I understand you comment, can you explain a bit better? is it hard to add on the admin part field for the the button? we have it for the main call to action button on the front page. Am I missing something? Let me know. |
|
@decidim/product this only applies to processes, right? Not assemblies, nor initiatives, only processes? Dev side: |
|
@mrcasals good question. This applies to processes and assemblies. Both host complicated mechanisms (process more than current use of organs) so it is very convenient to orient user actions though CTA button. |
|
@xabier Design needs to be adapted for assemblies then, as assemblies do not have steps and we cannot configure a new action per step (since they don't have any). I assumed this was only for processes since the design issue (decidim-archive/design#161) and this one specify "process" in their title. /cc @decidim/product If this needs to be applied to assemblies too then we need to find an admin UI for this for assemblies, because I can't figure out how to solve this. Edit: I've removed a sentence that could be read as too aggressive, sorry all. |
|
Also, @Crashillo, this PR has conflicts 😄 |
|
Ready to be reviewed |
mrcasals
left a comment
There was a problem hiding this comment.
Code looks good, sorry for the late review!
|
Merging this some we can move forward! |
🎩 What? Why?
Redesign the process phases widget
📌 Related Issues
📋 Subtasks
📷 Screenshots (optional)