Skip to content

CTA process home#2440

Merged
mrcasals merged 4 commits intomasterfrom
design/cta-home
Feb 16, 2018
Merged

CTA process home#2440
mrcasals merged 4 commits intomasterfrom
design/cta-home

Conversation

@Crashillo
Copy link
Copy Markdown
Contributor

@Crashillo Crashillo commented Jan 5, 2018

🎩 What? Why?

Redesign the process phases widget

📌 Related Issues

📋 Subtasks

  • None

📷 Screenshots (optional)

imagen

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 5, 2018

Codecov Report

Merging #2440 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2440   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files        1446     1446           
  Lines       33973    33973           
=======================================
  Hits        33582    33582           
  Misses        391      391

@josepjaume
Copy link
Copy Markdown
Contributor

Hi! Not sure how can we implement this, as a process can have many components and any component several call to actions. Have you thought about an admin interface for this?

@mrcasals
Copy link
Copy Markdown
Contributor

mrcasals commented Jan 8, 2018

I've edited the description of this PR to point to decidim-archive/design#161 instead of #161

@xabier
Copy link
Copy Markdown

xabier commented Jan 8, 2018

Hi! Not sure how can we implement this, as a process can have many components and any component several call to actions. Have you thought about an admin interface for this?

@josepjaume like other configurable call to action buttons on Decidim, can we just not add a local address for the active component?

Copy link
Copy Markdown
Contributor

@josepjaume josepjaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me! Does this require adapting any currently existing markup?

@Crashillo
Copy link
Copy Markdown
Contributor Author

It does. Currently there are two templates quite similar _process_phase_home.html.erb and _process_phase.html.erb. This PR applies to the first one. I'm not sure about why there are two, apart from a couple of changes, they might be handle with conditional rendering.

@josepjaume
Copy link
Copy Markdown
Contributor

Well, what I meant is "do I need to adapt the currently existing markup or the UI will break"? We don't have a way on the admin UI to actually set an action for the button, so we won't show it for the moment.

@xabier
Copy link
Copy Markdown

xabier commented Feb 6, 2018

@josepjaume not sure I understand you comment, can you explain a bit better? is it hard to add on the admin part field for the the button? we have it for the main call to action button on the front page. Am I missing something? Let me know.

@mrcasals
Copy link
Copy Markdown
Contributor

mrcasals commented Feb 7, 2018

@decidim/product this only applies to processes, right? Not assemblies, nor initiatives, only processes?

Dev side:
In order to actually implement this, we need to modify the admin section to add these fields. I guess we could reuse the same fields we use for the CTA in the homepage (URL & text), but we'd need to modify ParticipatoryProcessStep model to add these fields.

@xabier
Copy link
Copy Markdown

xabier commented Feb 8, 2018

@mrcasals good question. This applies to processes and assemblies. Both host complicated mechanisms (process more than current use of organs) so it is very convenient to orient user actions though CTA button.

@mrcasals
Copy link
Copy Markdown
Contributor

mrcasals commented Feb 9, 2018

@xabier Design needs to be adapted for assemblies then, as assemblies do not have steps and we cannot configure a new action per step (since they don't have any).

I assumed this was only for processes since the design issue (decidim-archive/design#161) and this one specify "process" in their title.

/cc @decidim/product

If this needs to be applied to assemblies too then we need to find an admin UI for this for assemblies, because I can't figure out how to solve this.

Edit: I've removed a sentence that could be read as too aggressive, sorry all.

@mrcasals
Copy link
Copy Markdown
Contributor

mrcasals commented Feb 9, 2018

Also, @Crashillo, this PR has conflicts 😄

@ghost ghost added the in-progress label Feb 9, 2018
@Crashillo
Copy link
Copy Markdown
Contributor Author

Ready to be reviewed

Copy link
Copy Markdown
Contributor

@mrcasals mrcasals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, sorry for the late review!

@mrcasals
Copy link
Copy Markdown
Contributor

Merging this some we can move forward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants