Add react-on-rails on a isolated engine to test it#241
Add react-on-rails on a isolated engine to test it#241beagleknight wants to merge 1 commit intomasterfrom
Conversation
|
@beagleknight, thanks for your PR! By analyzing the history of the files in this pull request, we identified @josepjaume, @mrcasals and @oriolgual to be potential reviewers. |
| @@ -0,0 +1,4 @@ | |||
| # desc "Explaining what the task does" | |||
There was a problem hiding this comment.
Missing frozen string literal comment.
| require "decidim/comments/engine" | ||
|
|
||
| module Decidim | ||
| module Comments |
There was a problem hiding this comment.
Missing top-level module documentation comment.
|
For this is really important to have some kind of progressive enhancement. This is a good reading regarding this: https://gdstechnology.blog.gov.uk/2016/09/19/why-we-use-progressive-enhancement-to-build-gov-uk/ |
|
Hi @andreslucena I'm agree with the progressive enchancement approach. We are aiming for rendering the component on server side so they can be visualized without javascript. We are gonna start simple, a basic comment box to put new comments without hierarchy. |
|
I'm closing this in favor of #250 |
🎩 What? Why?
As a starting point of our comments module we need to include some way to render react components on our application. As discussed here #215 we are gonna try
react-on-rails.I want to test this in a isolated engine so we can iterate from here to create the comments module.
📌 Related Issues
📋 Subtasks
react-on-rails📷 Screenshots (optional)
None
👻 GIF
None