Merged
Conversation
mrcasals
previously approved these changes
Oct 10, 2017
16 tasks
Previously the handler name was kept in both the data hash and a specific `handler_name` attribute, and these attributes were both accessed inconsistenly. I stopped writing & reading the handler name to and from the data hash, and always use the attribute accesor.
No unnecessary fetch, no double access to hash value, no unnecessary `to_a` since AR delegates `find` to `Array` when a block is passed.
779a4bc to
e373e92
Compare
Codecov Report
@@ Coverage Diff @@
## master #2019 +/- ##
==========================================
+ Coverage 98.48% 98.48% +<.01%
==========================================
Files 1145 1145
Lines 25775 25780 +5
==========================================
+ Hits 25384 25389 +5
Misses 391 391 |
mrcasals
approved these changes
Oct 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
A couple of refactorings in action authorization so they are easier to understand.
📌 Related Issues
None.
📋 Subtasks
None.
📷 Screenshots (optional)
None.
👻 GIF