Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

decidim-assemblies/spec/system/admin/admin_manages_assemblies_spec.rb (1)

135-149: Redundant before block still causes the assemblies path to be visited three times.

The inner before at lines 138–140 re-visits decidim_admin_assemblies.assemblies_path, but the outer shared_examples "updating an assembly" before at lines 110–112 already does so. When this example runs inside the "when managing parent assemblies" context, the full before chain visits the path three times (context → shared_examples → inner describe). The previous review also proposed removing the sidebar navigation step, which the author addressed by removing it globally; only the redundant before removal remains.

♻️ Proposed fix

     describe "when the assembly is transparent" do
       let!(:assembly3) { create(:assembly, :private, :transparent, organization:) }
 
-      before do
-        visit decidim_admin_assemblies.assemblies_path
-      end
-
       it "shows the transparent checkbox correctly" do
         within "tr", text: translated(assembly3.title) do
           click_on translated(assembly3.title)
         end
 
         expect(page).to have_checked_field("assembly_is_transparent")
       end
     end

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@decidim-assemblies/spec/system/admin/admin_manages_assemblies_spec.rb` around
lines 135 - 149, The inner before block that calls visit
decidim_admin_assemblies.assemblies_path is redundant because the outer
shared_examples "updating an assembly" and the context already visit that path;
remove the inner before (the one wrapping visit
decidim_admin_assemblies.assemblies_path inside the "when the assembly is
transparent" describe) so the example using let!(:assembly3) still visits the
page only once via the shared_examples setup and then assert
have_checked_field("assembly_is_transparent") within the row for
translated(assembly3.title).

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

decidim-assemblies/spec/system/admin/admin_manages_assemblies_spec.rb (1)

138-144: Navigate to the edit form before asserting the checkbox.

After clicking the assembly title, the UI typically lands on the components page, not the edit form that contains assembly_is_transparent. Add the sidebar navigation step so the assertion targets the correct page.

🐛 Proposed fix

       it "shows the transparent checkbox correctly" do
         within "tr", text: translated(assembly3.title) do
           click_on translated(assembly3.title)
         end
+
+        within_admin_sidebar_menu do
+          click_on "About this assembly"
+        end
 
         expect(page).to have_checked_field("assembly_is_transparent")
       end

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@decidim-assemblies/spec/system/admin/admin_manages_assemblies_spec.rb` around
lines 138 - 144, After clicking the assembly title (the click_on
translated(assembly3.title) in the spec), add a step to navigate to the assembly
edit form via the sidebar before asserting the checkbox; e.g., within the
sidebar (or navigation region) click the edit link so the test is on the edit
page that contains the assembly_is_transparent field, then assert
expect(page).to have_checked_field("assembly_is_transparent").

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro