Fix can_participate? into ParticipatoryProcessStep by alecslupu · Pull Request #16008 · decidim/decidim

alecslupu · 2026-02-05T22:07:43Z

🎩 What? Why?

While i was trying to check the issue fixed by #15950 i went to the notifications path and i got served with an error, caused by activation of a new ParticipatoryProcessStep. This Step was activated when i have locally tested #15988

Additionally i am adding a spec for the work done in #15950.

📌 Related Issues

Link your PR to an issue

Related to Allow Attachment to answer to can_participate? based on it's attached model #15950
Related to Fix caching issue in processes content block #15988
Fixes #?

Testing

Login as admin
Visit the Participatory process frontend site & make sure you follow it
Visit a participatory process in admin
Create a new ParticipatoryProcessStep & activate
Visit the frontend site
Go to your notifications
See error
Apply patch
See error is gone

To validate the spec, switch to this branch, edit the Attachment work and revert the work done in #15950, then run: ./bin/rspec decidim-participatory_processes/spec/system/admin/admin_manages_participatory_process_attachments_spec.rb

You should see an error similar with the above.

📷 Screenshots

Please add screenshots of the changes you are proposing

♥️ Thank you!

Summary by CodeRabbit

New Features
- Participatory process steps can directly access participation eligibility from their parent process.
Tests
- Added system tests covering notifications when participatory process steps are activated.
- Added system tests verifying notifications after attachments are added to participatory processes and assemblies.

coderabbitai · 2026-02-05T22:08:10Z

📝 Walkthrough

Walkthrough

Added a delegation in Decidim::ParticipatoryProcessStep to forward can_participate? to its participatory process, and expanded system specs to assert notification behavior for step activation and attachment creation.

Changes

Cohort / File(s)	Summary
Model Delegation `decidim-participatory_processes/app/models/decidim/participatory_process_step.rb`	Added `delegate :can_participate?, to: :participatory_process` to forward participation checks from step to its parent process.
Participatory Process Step Tests `decidim-participatory_processes/spec/system/participatory_process_steps_spec.rb`	Added a "when activating a step" context that sets up a confirmed user and follow, activates a step, waits for enqueued jobs, and asserts a notification mentioning the phase activation.
Attachment Notification Tests `decidim-assemblies/spec/system/admin/admin_manages_assembly_attachments_spec.rb`, `decidim-participatory_processes/spec/system/admin/admin_manages_participatory_process_attachments_spec.rb`	Wrapped existing attachment management examples with a "when checking notifications" context and added tests creating follows, submitting attachments (multilingual), and asserting notifications appear after enqueued jobs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Possibly related PRs

Allow Attachment to answer to can_participate? based on it's attached model #15950: Adds a delegation for can_participate? in a related model, indicating a similar pattern of forwarding calls to associated objects.
Fix caching issue in processes content block #15988: Modifies Decidim::ParticipatoryProcessStep at the association level (touch: true), touching the same class as this change.

Suggested reviewers

andreslucena
github-actions

Poem

🐰 I hop, I nudge, I softly say,

"Can you take part?" — I pass the way.
Notifications ring, attachments land,
Steps awaken at my command,
Code carrot cheer — a delightful day! 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding a delegation to forward the can_participate? method to ParticipatoryProcessStep, which directly addresses the NoMethodError documented in the PR objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/can-participate

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This pull request fixes a missing can_participate? method in ParticipatoryProcessStep that caused errors when viewing notifications after a step activation. The fix delegates the method to the parent participatory_process, following the established pattern used by other child models like Component and Attachment. The PR also adds comprehensive test coverage for both the step activation notification flow and the attachment notification flow (related to PR #15950).

Changes:

Added delegation of can_participate? from ParticipatoryProcessStep to its parent participatory_process
Added system test for step activation notifications to ensure the fix works correctly
Refactored and enhanced attachment tests to validate that attachment notifications display properly (coverage for PR #15950)

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
`decidim-participatory_processes/app/models/decidim/participatory_process_step.rb`	Adds `delegate :can_participate?, to: :participatory_process` to fix notification rendering errors
`decidim-participatory_processes/spec/system/participatory_process_steps_spec.rb`	Adds test case for step activation notification display to verify the fix
`decidim-admin/lib/decidim/admin/test/manage_attachments_examples.rb`	Refactors attachment creation test and adds new test for attachment notifications to verify PR #15950

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

This reverts commit 53b6cd6.

andreslucena

Only a quick change clarifying the example

decidim-participatory_processes/spec/system/participatory_process_steps_spec.rb

…ess_steps_spec.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

alecslupu · 2026-02-06T08:56:41Z

@andreslucena This is ready for another look

andreslucena · 2026-02-06T09:54:49Z

Merging with the only failure of qlty coverage (a bug on simplecov/parallel specs/GH retries, as it says that's -15% but that doesn't make much sense)

alecslupu added 2 commits February 5, 2026 23:14

Fix can_participate into ParticipatoryProcessStep

ba63b73

Add spec for attachments

53b6cd6

Copilot AI review requested due to automatic review settings February 5, 2026 22:07

alecslupu added release: v0.30 Issues or PRs that need to be tackled for v0.30 release: v0.31 Issues or PRs that need to be tackled for v0.31 labels Feb 5, 2026

Copilot started reviewing on behalf of alecslupu February 5, 2026 22:08 View session

github-actions bot added module: admin module: participatory processes type: fix PRs that implement a fix for a bug labels Feb 5, 2026

github-actions bot previously approved these changes Feb 5, 2026

View reviewed changes

Copilot AI reviewed Feb 5, 2026

View reviewed changes

alecslupu added 2 commits February 6, 2026 00:51

Revert "Add spec for attachments"

5cac407

This reverts commit 53b6cd6.

Refactor attachment specs

7cc39ff

alecslupu dismissed github-actions[bot]’s stale review via 7cc39ff February 5, 2026 23:01

github-actions bot added the module: assemblies label Feb 5, 2026

github-actions bot previously approved these changes Feb 5, 2026

View reviewed changes

andreslucena requested changes Feb 6, 2026

View reviewed changes

decidim-participatory_processes/spec/system/participatory_process_steps_spec.rb Outdated Show resolved Hide resolved

andreslucena self-assigned this Feb 6, 2026

Update decidim-participatory_processes/spec/system/participatory_proc…

ffb63e8

…ess_steps_spec.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

alecslupu dismissed github-actions[bot]’s stale review via ffb63e8 February 6, 2026 08:26

github-actions bot approved these changes Feb 6, 2026

View reviewed changes

andreslucena mentioned this pull request Feb 6, 2026

Add cop rule for bad usage of have_admin_callout #16011

Merged

andreslucena approved these changes Feb 6, 2026

View reviewed changes

andreslucena merged commit 6aeaffc into develop Feb 6, 2026
52 of 53 checks passed

andreslucena deleted the fix/can-participate branch February 6, 2026 09:54

This was referenced Feb 6, 2026

Backport 'Fix can_participate? into ParticipatoryProcessStep' to v0.31 #16012

Merged

Backport 'Fix can_participate? into ParticipatoryProcessStep' to v0.30 #16013

Merged

davidbeig mentioned this pull request Mar 16, 2026

Daily digest does not include notifications that trigger real-time emails #16143

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix can_participate? into ParticipatoryProcessStep#16008

Fix can_participate? into ParticipatoryProcessStep#16008
andreslucena merged 5 commits intodevelopfrom
fix/can-participate

alecslupu commented Feb 5, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 5, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

Copilot AI left a comment

Uh oh!

andreslucena left a comment

Uh oh!

Uh oh!

alecslupu commented Feb 6, 2026

Uh oh!

andreslucena commented Feb 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

alecslupu commented Feb 5, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎩 What? Why?

📌 Related Issues

Testing

📷 Screenshots

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

andreslucena left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alecslupu commented Feb 6, 2026

Uh oh!

andreslucena commented Feb 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alecslupu commented Feb 5, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 5, 2026 •

edited

Loading