Fix proposal import with other proposals states in budgets#15630
Merged
Fix proposal import with other proposals states in budgets#15630
Conversation
|
Looking at it plainly from a functional perspective: love it @greenwoodt , thanks! |
alecslupu
reviewed
Dec 17, 2025
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
alecslupu
approved these changes
Dec 24, 2025
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
👍
Merging with codecov failure.
This was referenced Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Allows the importing of published proposals within budgets based on a acceptance state of values:
accepted,rejected,not_answered,evaluatingand any created state within proposals attributeinternal_states.Custom states are saved to the
internal_statesattribute as a string, which allows us to iterate over the state options as a collection. In order to make this import work, I've needed to adapt theproposalmethod in the proposal to budgets command to check for these custom states and order them accordingly by theirpublished_atvalue.Adding a cost to the form is also attributed to the desired imported published proposals.
If none are ticked, ALL proposals answered will be imported and multiple option states are also a option as per request.
This PR also incorporates the option to import proposals as projects from the component which are "not_answered", allowing admins more flexibility managing the budgets module.
📌 Related Issues
Testing
Testing via new
internal_states📷 Screenshots
NEW STATE OPTION:

FILTERED & ANSWERED WITH NEW STATE:

CURRENTLY IMPORTED PUBLISHED PROPOSALS WITH ACCEPTED STATE:

IMPORT PROPOSALS FROM IN BUDGETS WITH NEW STATE:

SUCCESSFUL IMPORT OF CUSTOM STATE:

IMPORTED ASSIGNED COST:
