Skip to content

No longer generate the initializer files#14832

Merged
andreslucena merged 28 commits intodevelopfrom
chore/avoid-decidim-initializer
Jul 3, 2025
Merged

No longer generate the initializer files#14832
andreslucena merged 28 commits intodevelopfrom
chore/avoid-decidim-initializer

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

🎩 What? Why?

Since we are relying solely on environment variables to configure the application, we are removing the generatror

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📷 Screenshots

Please add screenshots of the changes you are proposing
Description

♥️ Thank you!

@github-actions github-actions bot added module: generators type: internal PRs that aren't necessary to add to the CHANGELOG for implementers labels Jun 9, 2025
github-actions[bot]
github-actions bot previously approved these changes Jun 9, 2025
github-actions[bot]
github-actions bot previously approved these changes Jun 13, 2025
github-actions[bot]
github-actions bot previously approved these changes Jun 16, 2025
github-actions[bot]
github-actions bot previously approved these changes Jul 2, 2025
github-actions[bot]
github-actions bot previously approved these changes Jul 2, 2025
@alecslupu
Copy link
Copy Markdown
Contributor Author

rg initializers/decidim.rb docs

When we are refering to this, i have left behind 3 references:

  • docs/modules/install/pages/checklist.adoc:25 - Review initializer if file exists
  • docs/modules/configure/pages/environment_variables.adoc:5 - Custom applications may implement a decidim initializer (config/initializers/decidim.rb) in such a way that this will have no effect.
  • docs/modules/services/pages/maps.adoc - There are some advanced configuration, that may be required in the geocoding part, so we need to allow users to create advanced config

github-actions[bot]
github-actions bot previously approved these changes Jul 2, 2025
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
github-actions[bot]
github-actions bot previously approved these changes Jul 3, 2025
github-actions[bot]
github-actions bot previously approved these changes Jul 3, 2025
@alecslupu
Copy link
Copy Markdown
Contributor Author

I think this is missing - or tell me if what you think about this comment :)

Whoops, initially i thought that it may be more complex, but did it in 096256d

@alecslupu
Copy link
Copy Markdown
Contributor Author

Can you apply this change?

Done in 8303e8b

@alecslupu alecslupu requested a review from andreslucena July 3, 2025 11:36
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only doubt that I have is related to the initializer doc page (docs/modules/configure/pages/initializer.adoc) - but I want to first merge this and think in an alternative for a couple days, as I'm not 100% sure about it.

@andreslucena andreslucena merged commit 2fb92db into develop Jul 3, 2025
78 of 79 checks passed
@andreslucena andreslucena deleted the chore/avoid-decidim-initializer branch July 3, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment