Only precompile test app assets on CI#1392
Conversation
decidim-dev/lib/tasks/test_app.rake
Outdated
|
|
||
| end | ||
|
|
||
| task :generate_static_test_app => :generate_test_app do |
There was a problem hiding this comment.
The NEW Ruby 1.9 hash syntax 🖖
|
@josepjaume, thanks for your PR! By analyzing the history of the files in this pull request, we identified @beagleknight and @deivid-rodriguez to be potential reviewers. |
622e41b to
4ccd42d
Compare
decidim-dev/lib/tasks/test_app.rake
Outdated
| end | ||
|
|
||
| def dummy_app_path | ||
| dummy_app_path = File.expand_path(File.join(Dir.pwd, "spec", "decidim_dummy_app")) |
There was a problem hiding this comment.
Useless assignment to variable - dummy_app_path.
4ccd42d to
9a4911a
Compare
|
This is really cool @josepjaume! There is a problem in the CI tho :/ |
|
Yeah, looking forward to this! :) |
9a4911a to
6d5843d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1392 +/- ##
=======================================
Coverage 95.42% 95.42%
=======================================
Files 428 428
Lines 7365 7365
=======================================
Hits 7028 7028
Misses 337 337 |
beagleknight
left a comment
There was a problem hiding this comment.
Can you add the CI variable to the circle ci config as well? line 6 😄
|
Already there by default, as in most CI's: https://circleci.com/docs/1.0/environment-variables/ |
|
I wasn't sure about the CircleCi 2.0 because we are using custom containers 😄 |
🎩 What? Why?
Using the test app locally forces us to recompile assets every time something is changed. This deals with it by only precompiling assets using a specific task meant for CI environments.
📌 Related Issues
📋 Subtasks
None
📷 Screenshots (optional)
None
👻 GIF