Skip to content

Enable bullet while running specs#138

Merged
oriolgual merged 1 commit intomasterfrom
chore/integrate_bullet
Oct 21, 2016
Merged

Enable bullet while running specs#138
oriolgual merged 1 commit intomasterfrom
chore/integrate_bullet

Conversation

@oriolgual
Copy link
Copy Markdown
Contributor

🎩 What? Why?

Integrate bullet to the test suite so we can detect N+1 and related errors!

👻 GIF

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 20, 2016

Current coverage is 97.64% (diff: 100%)

Merging #138 into master will increase coverage by 0.01%

@@             master       #138   diff @@
==========================================
  Files           151        154     +3   
  Lines          2237       2255    +18   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           2184       2202    +18   
  Misses           53         53          
  Partials          0          0          

Powered by Codecov. Last update 884b35b...289f15a

@oriolgual oriolgual force-pushed the chore/integrate_bullet branch from b01f477 to 2cdbcf6 Compare October 21, 2016 07:31
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HAH

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOLOLO @houndci-bot finding runtime errors

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And Code Climate not

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is valid Ruby.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is valid Ruby.

@oriolgual oriolgual force-pushed the chore/integrate_bullet branch from 2cdbcf6 to d6d1f53 Compare October 21, 2016 07:54
@oriolgual oriolgual force-pushed the chore/integrate_bullet branch from d6d1f53 to 289f15a Compare October 21, 2016 08:10
@oriolgual oriolgual merged commit 369cf5b into master Oct 21, 2016
@oriolgual oriolgual deleted the chore/integrate_bullet branch October 21, 2016 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants