Add Paranoia gem#13668
Merged
microstudi merged 9 commits intodecidim:feature/soft-delete-for-spaces-componentsfrom Nov 18, 2024
Merged
Add Paranoia gem#13668microstudi merged 9 commits intodecidim:feature/soft-delete-for-spaces-componentsfrom
microstudi merged 9 commits intodecidim:feature/soft-delete-for-spaces-componentsfrom
Conversation
Contributor
Author
|
Assigning to @microstudi and @antopalidi to validate the changes, as it impacts their deliverable. |
microstudi
approved these changes
Nov 18, 2024
Contributor
microstudi
left a comment
There was a problem hiding this comment.
I have to say, I was skeptic about using this gem.
Seeing the changes it allows, I like it very much. This default scope is much cleaner.
Thanks Alecs, shame we didn't knew about the Paranoia gem before starting this PR.
aa2ed3a
into
decidim:feature/soft-delete-for-spaces-components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
While reviewing #13297, i noticed there are some issues with the data retrievals, that i have posted in this #13297 (review)
As @andreslucena pointed out in #13297 (comment) we decided to push for paranoia gem.
This PR adds paranoia.
📌 Related Issues
Link your PR to an issue
Testing