Skip to content

Update open data exports for Results #13667

Merged
andreslucena merged 15 commits intodecidim:developfrom
greenwoodt:change/csv-exports-results
Nov 18, 2024
Merged

Update open data exports for Results #13667
andreslucena merged 15 commits intodecidim:developfrom
greenwoodt:change/csv-exports-results

Conversation

@greenwoodt
Copy link
Copy Markdown
Member

@greenwoodt greenwoodt commented Nov 15, 2024

🎩 What? Why?

Update of columns for the csv_export of the Results component. This is a part of on going work in Ref: MGOV06

📌 Related Issues

Testing

  1. Load the branch locally
  2. rebuild the development_app
  3. Launch app locally to the browser
  4. Head to the footer and find & click the "Open Data" link
  5. Download Results CSV
  6. See newly added columns

run decidim-accountability/spec/services/decidim/accountability/result_serializer_spec.rb

📷 Screenshots

♥️ Thank you!

@greenwoodt greenwoodt added module: accountability type: change PRs that implement a change for an existing feature project: 2024-flatfiles Metagov grant labels Nov 15, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 15, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 15, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 15, 2024
@greenwoodt greenwoodt changed the title Results CSV export update Results Open Data CSV export update Nov 15, 2024
@greenwoodt greenwoodt marked this pull request as ready for review November 15, 2024 15:29
github-actions[bot]
github-actions bot previously approved these changes Nov 15, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 15, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 15, 2024
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few details and this is ready for the merge

@andreslucena andreslucena changed the title Results Open Data CSV export update Update open data exports for Results Nov 18, 2024
…sult_serializer_spec.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
greenwoodt and others added 4 commits November 18, 2024 13:12
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@greenwoodt
Copy link
Copy Markdown
Member Author

greenwoodt commented Nov 18, 2024

Just a few details and this is ready for the merge

I've updated the locales to represent the corresponding component.

@andreslucena
Copy link
Copy Markdown
Member

Merging with the only failure of codecov

@andreslucena andreslucena merged commit 7c31dcf into decidim:develop Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: accountability project: 2024-flatfiles Metagov grant type: change PRs that implement a change for an existing feature

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants