Skip to content

Design update to comments #13205

Merged
alecslupu merged 61 commits intodecidim:developfrom
greenwoodt:fix/update-comments-design
Oct 18, 2024
Merged

Design update to comments #13205
alecslupu merged 61 commits intodecidim:developfrom
greenwoodt:fix/update-comments-design

Conversation

@greenwoodt
Copy link
Copy Markdown
Member

@greenwoodt greenwoodt commented Jul 24, 2024

🎩 What? Why?

This PR introduces frontend CSS overhaul to comments throughout the Decidim platform. These changes have been made in accordance with the provided designs

Thanks to @andreslucena and @alecslupu for the support!

  • Resources such as (Recent or Best rated) are located into a select dropdown.
  • The comments container has been restructured
  • The replies button has moved the bottom centre of the container as per scope
  • The replies and the children replies are now in a separate container when expanded with a dim RBGA color shade, not joined with the same parent comments container.

📌 Related Issues

Testing

  1. Head over to Decidim.
  2. Click a component with comments enabled like Meetings.
  3. Scroll to the bottom of the component and see the changes.

📷 Screenshots

♥️ Thank you!

@greenwoodt greenwoodt added module: core type: change PRs that implement a change for an existing feature labels Jul 24, 2024
github-actions[bot]
github-actions bot previously approved these changes Jul 24, 2024
github-actions[bot]
github-actions bot previously approved these changes Jul 25, 2024
github-actions[bot]
github-actions bot previously approved these changes Jul 25, 2024
github-actions[bot]
github-actions bot previously approved these changes Jul 25, 2024
github-actions[bot]
github-actions bot previously approved these changes Jul 25, 2024
github-actions[bot]
github-actions bot previously approved these changes Jul 25, 2024
github-actions[bot]
github-actions bot previously approved these changes Aug 19, 2024
github-actions[bot]
github-actions bot previously approved these changes Aug 19, 2024
github-actions[bot]
github-actions bot previously approved these changes Oct 15, 2024
github-actions[bot]
github-actions bot previously approved these changes Oct 16, 2024
github-actions[bot]
github-actions bot previously approved these changes Oct 16, 2024
alecslupu
alecslupu previously approved these changes Oct 16, 2024
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

github-actions[bot]
github-actions bot previously approved these changes Oct 17, 2024
github-actions[bot]
github-actions bot previously approved these changes Oct 17, 2024
carolromero
carolromero previously approved these changes Oct 17, 2024
Copy link
Copy Markdown
Member

@carolromero carolromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greenwoodt from the product point of view this is ready to be merged, as we need to open more issues related to the work you have done. Thank you!

@greenwoodt greenwoodt requested a review from alecslupu October 17, 2024 11:54
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Merging with codecov failing pipeline.

@alecslupu alecslupu added this to the 0.30.0 milestone Oct 18, 2024
@alecslupu alecslupu merged commit 4446b1c into decidim:develop Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code module: comments module: core type: change PRs that implement a change for an existing feature

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

Update comments design

4 participants