Change the "cancel your registration" button in meetings#13127
Merged
alecslupu merged 68 commits intodecidim:developfrom Sep 20, 2024
Merged
Change the "cancel your registration" button in meetings#13127alecslupu merged 68 commits intodecidim:developfrom
alecslupu merged 68 commits intodecidim:developfrom
Conversation
2 tasks
…lation button within the meeting_aside partial
alecslupu
suggested changes
Sep 19, 2024
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
1-2 more chages clarifications, and we should be able to merge it.
decidim-meetings/app/views/decidim/meetings/meetings/_meeting_aside.html.erb
Outdated
Show resolved
Hide resolved
…aside.html.erb Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
e5b6788
I have taken over the review from Andres. Dismissing to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Changes made to redesign of the meetings registration page in Meetings. These changes incorporate CSS changes to buttons and arrangement to containers within the page.
These have been done according to proposed layout provided in: https://www.figma.com/proto/1oiYPbgbpYCXDlizz9bSxs/Internal-Decidim?node-id=9-1287&t=8ClRk0Cne2Mceyal-1&scaling=min-zoom&content-scaling=fixed&page-id=1%3A66
📌 Related Issues
Testing
📷 Screenshots
Mobile view:
