Fix i18n string misplacement in decidim-initiatives#12874
Merged
andreslucena merged 2 commits intodevelopfrom May 30, 2024
Merged
Fix i18n string misplacement in decidim-initiatives#12874andreslucena merged 2 commits intodevelopfrom
andreslucena merged 2 commits intodevelopfrom
Conversation
|
It seems like you did not give us much information about what you are trying to do here. We would appreciate it if you could provide us with more info about this issue/PR! |
andreslucena
requested changes
May 29, 2024
Member
andreslucena
left a comment
There was a problem hiding this comment.
Great finding! I found another one related to this one, when going to a Components' manage page in the admin (as Proposals) without decidim-initiatives.
Can you add it please?
diff --git a/decidim-admin/config/locales/en.yml b/decidim-admin/config/locales/en.yml
index ecb057ac4c..09175b5b03 100644
--- a/decidim-admin/config/locales/en.yml
+++ b/decidim-admin/config/locales/en.yml
@@ -571,6 +571,7 @@ en:
appearance: Appearance
area_types: Area types
areas: Areas
+ components: Components
configuration: Configuration
content: Reported content
external_domain_allowlist: Allowed external domains
diff --git a/decidim-initiatives/config/locales/en.yml b/decidim-initiatives/config/locales/en.yml
index 83e556be63..e66e373e03 100644
--- a/decidim-initiatives/config/locales/en.yml
+++ b/decidim-initiatives/config/locales/en.yml
@@ -106,7 +106,6 @@ en:
menu:
attachments: Attachments
committee_members: Committee members
- components: Components
information: Information
initiative_type_scopes: Initiative type scopes
initiatives: Initiatives
Contributor
Author
nice! applied! |
andreslucena
approved these changes
May 29, 2024
Member
|
Adding the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
If you don't enable initiatives, which is very common on Decidim for organizations, you will notice that the top menu for components in the admin shows the raw i18n key "decidim.admin.actions.manage".
This is because this key is defined in the en.yml file on initiatives. It should be in the admin module.
This should backported as it's there from long time ago.
📌 Related Issues
Link your PR to an issue
Testing
Just' don't install initiatives, run decidim, try to administrate a component.
In production mode you will see a raw i18n key. In development it just breaks the application which makes development very uncomfortable.
📷 Screenshots
Please add screenshots of the changes you are proposing
