Redesign: Decidim Design Guide translation page (address)#12562
Redesign: Decidim Design Guide translation page (address)#12562andreslucena merged 10 commits intodecidim:developfrom
Conversation
…der method helper in controller
andreslucena
left a comment
There was a problem hiding this comment.
There's a git conflict here and also some missing translations in decidim-design/app/helpers/decidim/design/address_helper.rb, can you check them out please?
|
@greenwoodt git conflict and also the i18n-tasks failing. Can you check it out please? |
Due to the conflicts I'd prefer to wait until #12532 is merged before continuing. |
andreslucena
left a comment
There was a problem hiding this comment.
I've just realized that we're using the id as the value for the translation and also as the anchor tag. This is going to be a problem when sharing URLs as the fragment part will change in the different languages.
For the moment let's go on with what you're doing (using the i18n key in the id) and after all is merged we'll change this to use another key in the section hash, as I don't want to have broken URLs.
🎩 What? Why?
Decidim Design translations for the Address section.
📌 Related Issues
Testing
📷 Screenshots