Skip to content

Redesign: Decidim Design Guide translations (accordions)#12544

Merged
andreslucena merged 12 commits intodecidim:developfrom
greenwoodt:fix/design-module-translations/part-6
Mar 5, 2024
Merged

Redesign: Decidim Design Guide translations (accordions)#12544
andreslucena merged 12 commits intodecidim:developfrom
greenwoodt:fix/design-module-translations/part-6

Conversation

@greenwoodt
Copy link
Copy Markdown
Member

@greenwoodt greenwoodt commented Feb 29, 2024

🎩 What? Why?

i18n translations for the Accordions section of the Decidim design hub.

📌 Related Issues

Testing

  1. Generate a new development_app
  2. Go to http://localhost:3000/design
  3. Inspect the page.
  4. See the accordions section has been translated.

📷 Screenshots

♥️ Thank you!

@greenwoodt greenwoodt added type: internal PRs that aren't necessary to add to the CHANGELOG for implementers project: redesign Barcelona City Council contract labels Feb 29, 2024
github-actions[bot]
github-actions bot previously approved these changes Feb 29, 2024
@greenwoodt greenwoodt added this to the 0.29.0 milestone Feb 29, 2024
github-actions[bot]
github-actions bot previously approved these changes Feb 29, 2024
github-actions[bot]
github-actions bot previously approved these changes Feb 29, 2024
@andreslucena andreslucena changed the title Resdesign: Decidim Design Guide translations (accordions) Redesign: Decidim Design Guide translations (accordions) Feb 29, 2024
github-actions[bot]
github-actions bot previously approved these changes Feb 29, 2024
github-actions[bot]
github-actions bot previously approved these changes Feb 29, 2024
@greenwoodt greenwoodt requested a review from a team February 29, 2024 15:11
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the suggestions? Also there's a failing check (probably because of the unused string that I found, but I'm not 100% sure)

greenwoodt and others added 2 commits March 4, 2024 10:05
…html.erb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
github-actions[bot]
github-actions bot previously approved these changes Mar 4, 2024
@greenwoodt greenwoodt requested a review from andreslucena March 4, 2024 09:56
@andreslucena andreslucena merged commit 5a14a49 into decidim:develop Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project: redesign Barcelona City Council contract type: internal PRs that aren't necessary to add to the CHANGELOG for implementers

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants