Standardize the way resources are being listed in application#12328
Merged
andreslucena merged 10 commits intodevelopfrom Jan 26, 2024
Merged
Standardize the way resources are being listed in application#12328andreslucena merged 10 commits intodevelopfrom
andreslucena merged 10 commits intodevelopfrom
Conversation
andreslucena
requested changes
Jan 25, 2024
Member
andreslucena
left a comment
There was a problem hiding this comment.
I have a couple of doubts and suggestions... All in all I like the approach, I think we can stop the security issues much faster 👏🏽 👏🏽
decidim-core/lib/decidim/core/test/shared_examples/has_attachments.rb
Outdated
Show resolved
Hide resolved
2 tasks
andreslucena
approved these changes
Jan 26, 2024
This was referenced Jan 26, 2024
This was referenced Feb 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR aims to standardize the way the texts on factories are being used.
Also, We simplify the frontend by adding 2 helper methods
sanitize_translatedandescape_translated, which will allow us to avoid usingdecidim_sanitize(translated_attribute(model.name))📌 Related Issues
Testing